Date: Thu, 27 Feb 2003 06:00:30 -0800 (PST) From: Maxim Konovalov <maxim@macomnet.ru> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/48717: ipfw2 probability is wrong Message-ID: <200302271400.h1RE0U1o091258@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/48717; it has been noted by GNATS. From: Maxim Konovalov <maxim@macomnet.ru> To: Alex Popa <razor@ldc.ro> Cc: bug-followup@freebsd.org Subject: Re: kern/48717: ipfw2 probability is wrong Date: Thu, 27 Feb 2003 16:53:05 +0300 (MSK) Please try a patch below instead. Index: ipfw/ipfw2.c =================================================================== RCS file: /home/ncvs/src/sbin/ipfw/ipfw2.c,v retrieving revision 1.4.2.10 diff -u -r1.4.2.10 ipfw2.c --- ipfw/ipfw2.c 14 Jan 2003 19:15:59 -0000 1.4.2.10 +++ ipfw/ipfw2.c 27 Feb 2003 13:47:57 -0000 @@ -865,7 +865,7 @@ ipfw_insn_u32 *p = (ipfw_insn_u32 *)cmd; double d = 1.0 * p->d[0]; - d = 1 - (d / 0x7fffffff); + d = d / 0x7fffffff; printf("prob %f ", d); } break; @@ -2521,8 +2521,7 @@ if (d != 1) { /* 1 means always match */ action->opcode = O_PROB; action->len = 2; - *((int32_t *)(action+1)) = - (int32_t)((1 - d) * 0x7fffffff); + *((int32_t *)(action+1)) = (int32_t)(d * 0x7fffffff); action += action->len; } av += 2; ac -= 2; %%% -- Maxim Konovalov, maxim@macomnet.ru, maxim@FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200302271400.h1RE0U1o091258>