Date: Fri, 18 Dec 2009 13:27:20 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Ivan Voras <ivoras@freebsd.org> Cc: freebsd-current@freebsd.org Subject: Re: NOTES checker Message-ID: <86ljh0bh7b.fsf@ds4.des.no> In-Reply-To: <hgdqrv$rbm$2@ger.gmane.org> (Ivan Voras's message of "Thu, 17 Dec 2009 18:47:43 %2B0100") References: <200912161721.53540.jhb@freebsd.org> <hgdqrv$rbm$2@ger.gmane.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Ivan Voras <ivoras@freebsd.org> writes: > John Baldwin <jhb@freebsd.org> writes: > > I wrote a little script today that crawls through sys/conf/files*, > > sys/conf/options*, sys/conf/NOTES, and sys/*/conf/NOTES looking for dev= ices > > or options that are not tested in all the places they are valid. If fo= lks > > are interested I can commit it to src/tools. At the moment we have 300+ > > violations in HEAD. :) The first few look like this: > What does "tested" mean in this context? IIUC, it means "listed in NOTES on all arches that it claims to run on". > > WARN: device acpi_aiboost is defined globally but only tested in i386 N= OTES > > WARN: device acpi_asus is defined globally but only tested in i386 NOTES > > WARN: device acpi_dock is defined globally but only tested in i386 NOTES > > WARN: device acpi_fujitsu is defined globally but only tested in i386 N= OTES > > WARN: device acpi_hp is defined globally but only tested in i386 NOTES > > WARN: device acpi_ibm is defined globally but only tested in i386 NOTES > > WARN: option ACPI_MAX_TASKS is defined globally but never tested > > WARN: option ACPI_MAX_THREADS is defined globally but never tested > > WARN: device acpi_panasonic is defined globally but only tested in i386= NOTES > > WARN: device acpi_sony is defined globally but only tested in i386 NOTES > > WARN: device acpi_toshiba is defined globally but only tested in i386 N= OTES > > WARN: device acpi_video is defined globally but only tested in i386 NOT= ES > > WARN: device acpi_wmi is defined globally but only tested in i386 NOTES The bug here is not that they aren't tested outside i386, but that they are defined globally (although some of them, perhaps even all, are also valid on amd64) DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86ljh0bh7b.fsf>