Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 28 May 2002 18:01:19 +0900
From:      "Akinori MUSHA" <knu@iDaemons.org>
To:        Maxim Sobolev <sobomax@FreeBSD.org>
Cc:        ports@FreeBSD.org, bmah@FreeBSD.org
Subject:   Re: Bug in version comparison routine of pkg_version
Message-ID:  <86lma4fxy8.wl@archon.local.idaemons.org>
In-Reply-To: <3CF34321.C27E936F@FreeBSD.org>
References:  <3CF34321.C27E936F@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
At Tue, 28 May 2002 11:43:13 +0300,
sobomax wrote:
> For some reason pkg_version(1) thinks that version 1.7_5 is
> greater than version 1.7.0.1, but correctly reports that 1.7
> is less than 1.7.0.1. This doesn't look like a good thing to
> me and we probably should fix it before 4.6 is out. I don't
> know if portupgrade is affected, but I suspect that it could
> because AFAIK knu helped with implementing pkg_version's
> version comparison routine.

The comparison routine that the portupgrade suite uses handles it
correctly:

knu@archon[2]% pkg_version -t 1.7_5 1.7.0.1
>
knu@archon[2]% portversion -t 1.7_5 1.7.0.1
<

I remember Bruce modified my implementation slightly when making
pkg_version aware of PORTREVISION and PORTEPOCH.

Anyway, the right steps we should take are add the above case to
test-pkg_version.sh first and then fix pkg_version so the test suite
passes.

-- 
                     /
                    /__  __            Akinori.org / MUSHA.org
                   / )  )  ) )  /     FreeBSD.org / Ruby-lang.org
Akinori MUSHA aka / (_ /  ( (__(  @ iDaemons.org / and.or.jp

"Somewhere out of a memory.. of lighted streets on quiet nights.."

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86lma4fxy8.wl>