Date: Tue, 22 Sep 2009 14:51:06 +0300 From: Jaakko Heinonen <jh@saunalahti.fi> To: Warren Block <wblock@wonkity.com> Cc: freebsd-current@freebsd.org, Gonzalo Nemmi <gnemmi@gmail.com>, avg@FreeBSD.org, Thomas Quinot <thomas@freebsd.org> Subject: Re: core dump on kldload atapicam Message-ID: <20090922115106.GA2856@a91-153-125-115.elisa-laajakaista.fi> In-Reply-To: <alpine.BSF.2.00.0909210723520.3607@wonkity.com> References: <alpine.BSF.2.00.0909202116520.3416@lightning.wonkity.com> <19e9a5dc0909202237g1295b6d9hf69012745009eef4@mail.gmail.com> <20090921105458.GA86764@melamine.cuivre.fr.eu.org> <alpine.BSF.2.00.0909210723520.3607@wonkity.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2009-09-21, Warren Block wrote: > >> I can confirm that .. kldload atapicam still results in a "Fatal trap 12: > >> page fault while in kernel mode" on 8.0-RC1 The problem was introduced in r195534. Does the following patch work for you? %%% Index: sys/dev/ata/atapi-cam.c =================================================================== --- sys/dev/ata/atapi-cam.c (revision 197399) +++ sys/dev/ata/atapi-cam.c (working copy) @@ -418,8 +418,10 @@ atapi_action(struct cam_sim *sim, union break; } } - cpi->maxio = softc->ata_ch->dma.max_iosize ? - softc->ata_ch->dma.max_iosize : DFLTPHYS; + if (softc->ata_ch != NULL && softc->ata_ch->dma.max_iosize != 0) + cpi->maxio = softc->ata_ch->dma.max_iosize; + else + cpi->maxio = DFLTPHYS; ccb->ccb_h.status = CAM_REQ_CMP; xpt_done(ccb); return; %%% -- Jaakko
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090922115106.GA2856>