Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 17 Jan 2001 15:17:53 +0200
From:      Maxim Sobolev <sobomax@FreeBSD.org>
To:        Peter Pentchev <roam@orbitel.bg>
Cc:        ports@FreeBSD.org
Subject:   Re: RFC1: tool to automate common operations with patchfiles
Message-ID:  <3A659B81.C8791058@FreeBSD.org>
References:  <3A5F3B98.954D80A5@FreeBSD.org> <3A6332D9.11A6ABC6@FreeBSD.org> <20010117145238.R364@ringworld.oblivion.bg>

next in thread | previous in thread | raw e-mail | index | archive | help
Peter Pentchev wrote:

> On Mon, Jan 15, 2001 at 07:26:49PM +0200, Maxim Sobolev wrote:
> > Hi again,
> >
> > Just uploaded a somewhat improved version at:  http://people.freebsd.org/~sobomax/patchtool
> >
> > New in this revision:
> > - in the update mode (`-u') the tool is now honours last modification time of the patchfile, file from which diff to
> > be generated and ${PATCH_COOKIE} file to determine if the patchfile in question should be updated or it's already up
> > to date;
> > - more consistent error handling;
> > - cleaned up internal structure a bit;
> > - added several missed comments;
> > - fixed several typos/bugs.
> >
> > I'm going to commit it tomorrow, so please test it and let me know your feelings ;).
> >
>
> Just a minor I-have-not-tested-it-but-still-I-have-something-to-say comment ;)
>
> About DIFF_ARGS, PT_DIFF_ARGS and such.. people do know that diff(1) honors
> the DIFF_OPTIONS environment variable, right?
>
> G'luck,
> Peter (who cannot imagine life without DIFF_OPTIONS=-urN in .profile)

Honestly, I do not see why you can't have PT_DIFF_ARGS=-u in addition to DIFF_OPTIONS in your profile. I have no problems
making DIFF_OPTIONS an alias for PT_DIFF_ARGS, but IMO they are serving slightly different purposes and it may be
desirable to have them as a separate environment vars (hint: echo 'export PT_DIFF_ARGS=${DIFF_OPTIONS}'  >> ~/.profile :->
).

-Maxim



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3A659B81.C8791058>