Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 06 Dec 2009 11:18:04 +0100
From:      Gabor Kovesdan <gabor@FreeBSD.org>
To:        Adrian Chadd <adrian@FreeBSD.org>
Cc:        cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/www/lusca-head/files patch-ab patch-ac
Message-ID:  <4B1B84DC.3040104@FreeBSD.org>
In-Reply-To: <200912060958.nB69wwlm088487@repoman.freebsd.org>
References:  <200912060958.nB69wwlm088487@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Adrian Chadd escribió:
> adrian      2009-12-06 09:58:58 UTC
>
>   FreeBSD ports repository (src committer)
>
>   Added files:
>     www/lusca-head/files patch-ab patch-ac 
>   Log:
>   * Don't install the 'templates' error page directory. It isn't required.
>   * Default to "English" instead of "templates" in the configure script
And what about the PORTREVISION bump, which is mandatory after changing 
the install process? You know that, don't you? It would be better if you 
asked a ports committer to help you and especially to *approve* your 
changes. Your recent commits are far from any of our conventions. I 
don't even dare to ask if you tested this on a ports tinderbox. With 
your src commit bit you are able to commit to the ports tree but it 
doesn't mean that you can do whatever you want. It isn't quite usual 
that doc/ports committers ignore rules and commit something wrong to src 
without approval but it is much more common that src committers commit 
awkward doc and *especially* ports changes. I would like to call the 
community attention (not just yours) that the highest importance of the 
src tree doesn't mean that src committers can do whatever they want in 
the doc and ports trees. We have our own conventions and rules here, 
please respect them and ask approval from a ports committer if you are 
unsure. There are a lot of helpful people, who are glad to help and 
review patches. I also do that when I have time.

-- 
Gabor Kovesdan
FreeBSD Volunteer

EMAIL: gabor@FreeBSD.org .:|:. gabor@kovesdan.org
WEB:   http://people.FreeBSD.org/~gabor .:|:. http://kovesdan.org




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B1B84DC.3040104>