Date: Thu, 3 Jan 2013 18:57:48 +0000 From: "Robert N. M. Watson" <rwatson@FreeBSD.org> To: Andrew Turner <andrew@fubar.geek.nz> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r244899 - head/sys/mips/beri Message-ID: <7D95B3E5-5F9C-45D8-9C79-C0F6D4CE625D@FreeBSD.org> In-Reply-To: <20130103100258.2e22763f@fubar.geek.nz> References: <201212311106.qBVB6chM016661@svn.freebsd.org> <20130102081746.5435db05@fubar.geek.nz> <D89C1409-9D10-4C09-BBF8-E00CC9B6A57A@FreeBSD.org> <20130102110856.7c280fd5@fubar.geek.nz> <0E1E1A5C-BB34-4B82-828F-6FEE770A6037@FreeBSD.org> <20130103100258.2e22763f@fubar.geek.nz>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2 Jan 2013, at 21:02, Andrew Turner wrote: >> This seemed to do the trick; what do you think of the attached? This >> isn't a board-specific change, so I dropped it into the common >> fdt_mips.c code. On the other hand, this left it a bit open as to >> what the right compatible=3D line to use was, so feedback there most >> welcome. >=20 > The patch looks good. =46rom my reading of [1] the compatible value > should be something like "mips,mips4k" as it's value is of the form > "<manufacturer>,<model>". >=20 > I have been thinking the best way of merging these almost identical > decode functions. Linux appears to do it by providing a per-controller > function that can translate between the interrupt spec and the > configuration allowing them to have a generic parsing function that > doesn't need to check if the controller is compatible. I would like us > to have something similar as it will remove the duplicate function. Sounds good on tweaking the compatible value -- I'll do that my local = tree and merge to head fairly soon. I've now finished adapting our = current suite of device drivers to use FDT, which took a couple of days = but was fairly painless. On combining countless overlapping implementations: sounds reasonable to = me. Having a single implementation of a default parsing function = certainly wouldn't hurt -- or a single implementation of a generic one. Thanks, Robert=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7D95B3E5-5F9C-45D8-9C79-C0F6D4CE625D>