Date: Wed, 04 Aug 2010 17:22:52 +0300 From: Alexander Motin <mav@FreeBSD.org> To: Neel Natu <neelnatu@gmail.com> Cc: Randall Stewart <rrs@freebsd.org>, freebsd-mips@freebsd.org, Neel Natu <neel@freebsd.org> Subject: Re: [RFC] Event timers on MIPS Message-ID: <4C5977BC.1060104@FreeBSD.org> In-Reply-To: <AANLkTimqAitBoFyKT-8bE%2BS6%2B1wjnso569E3exrY6EWB@mail.gmail.com> References: <4C41A248.8090605@FreeBSD.org> <AANLkTilKYw4UqmfEee9zHGosEDzy4hiFob1d8R9jcB25@mail.gmail.com> <4C41B4CF.6080409@FreeBSD.org> <AANLkTik8_NGm7nKYXT1d1E4Vj6vYQPWHnnLDi78YnvQD@mail.gmail.com> <4C4205CC.6080700@FreeBSD.org> <AANLkTikUpqLeogkqxqWzzejp=7FstHX2wVRWNrYoWGCp@mail.gmail.com> <4C4ED247.80701@FreeBSD.org> <AANLkTiktMt87V5jXV0%2BnagHjpfTkBQ8Fu6CK7HqNXff3@mail.gmail.com> <AANLkTinH1itTauurEFCZVyz%2BW4T02niPV1jQeNART1Gm@mail.gmail.com> <4C555CF7.5080101@FreeBSD.org> <AANLkTimqAitBoFyKT-8bE%2BS6%2B1wjnso569E3exrY6EWB@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Neel Natu wrote: > Thanks for taking the time to review the patch. Here is the updated patch: > http://people.freebsd.org/~neel/tick_diff.txt Seems fine. > On Sun, Aug 1, 2010 at 4:39 AM, Alexander Motin <mav@freebsd.org> wrote: >> "t_upper++;" there looks a bit strange, as it is not written back. The >> wrapping stuff won't work if this timer interrupts were not used. > > This part is intentional. > > I wanted only clock_intr() to update the cached values of > 'counter_upper' and 'counter_lower_last' and tick_ticker() to sample a > consistent snapshot of the tuple and then operate on it. > > I have added an XXX comment to describe the dependency. We can revisit > this if we change the default timer in mips. It's not about default timer, but about having any other timer. But if you wish so, it should be enough for now. -- Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C5977BC.1060104>