Date: Wed, 12 May 2004 06:10:30 -0700 (PDT) From: Roman Neuhauser <neuhauser@chello.cz> To: java@FreeBSD.org Subject: Re: ports/66342: [PATCH] fix ECHO_MSG breakage in java ports Message-ID: <200405121310.i4CDAUY3033287@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/66342; it has been noted by GNATS. From: Roman Neuhauser <neuhauser@chello.cz> To: freebsd-gnats-submit@FreeBSD.org Cc: Subject: Re: ports/66342: [PATCH] fix ECHO_MSG breakage in java ports Date: Wed, 12 May 2004 15:06:41 +0200 # herve.quiroz@esil.univ-mrs.fr / 2004-05-12 12:33:39 +0200: > Roman, > > I recently tried to find a fix for this problem. I agree IGNORECMD has > to be changed to something else but with your patch the following page > still has problem: > > http://www.freshports.org/ports-ignore.php what kind of problem? you don't tell me what I should be looking for. > This solution (modifying bsd.port.mk) would benefit to other ports, such > as audio/gnump3d, databases/msql, games/linux-q3ademo... > > Attached is a patch I sent to Alexey lately. It's a bit of sed(1) magic > to justify output. I've got some problem with sed(1) when invoked from > make(1). That's why there are two lines added in bsd.port.mk: > > - The first one is the "correct" regular expression but it doesn't work > (that's why it is commented). right. you can't use the "\n" escape in replacement in the s command. > - The second is some kind of cheat, replacing '\n' by '%' in the regular > expression, and then filtering through tr(1) to produce 'n'. This is > quite ugly if you ask me but it works. it breaks ports whose IGNORE variable contains %. > --- bsd.port.mk.original Mon Apr 26 16:21:59 2004 > +++ bsd.port.mk Mon Apr 26 16:48:13 2004 > @@ -2577,7 +2577,8 @@ > .if defined(IGNORE_SILENT) > IGNORECMD= ${DO_NADA} > .else > -IGNORECMD= ${ECHO_MSG} "===> ${PKGNAME} ${IGNORE}." > +#IGNORECMD= ${ECHO_MSG} "===> ${PKGNAME} ${IGNORE}." | ${SED} 's/ */ /g ; s/[^ ]$$/ / ; s/.\{1,80\} /&\n/g' > +IGNORECMD= ${ECHO_MSG} "===> ${PKGNAME} ${IGNORE}." | ${SED} 's/ */ /g ; s/[^ ]$$/ / ; s/.\{1,80\} /&%/g' | ${TR} "%" "\n" > .endif > > .for target in check-sanity fetch checksum extract patch configure all build install reinstall package another problem is that the third subst, if it worked, would break long lines inside words, and would not reflow the text, producing short line overflows. moreover, this patch, goes against my recent push to reduce unnecessary commands in ${PORTSDIR}/Mk/*, so I guess it's not surprising I'm not terribly excited. -- FreeBSD 4.9-RELEASE-p2 1:25PM up 1 day, 5:46, 4 users, load averages: 0.00, 0.00, 0.00
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200405121310.i4CDAUY3033287>