Date: Mon, 28 Feb 2005 23:42:33 +0200 From: Ruslan Ermilov <ru@FreeBSD.org> To: "David O'Brien" <obrien@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile.inc1 src/share/mk bsd.compat.mk Message-ID: <20050228214233.GA6011@ip.net.ua> In-Reply-To: <20050228182618.GB56766@dragon.nuxi.com> References: <200502280923.j1S9NcKE004088@repoman.freebsd.org> <20050228093414.GA74879@ip.net.ua> <20050228093622.GB74879@ip.net.ua> <20050228182618.GB56766@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--2oS5YaxWCcQjTEyO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 28, 2005 at 10:26:18AM -0800, David O'Brien wrote: > On Mon, Feb 28, 2005 at 11:36:22AM +0200, Ruslan Ermilov wrote: > > On Mon, Feb 28, 2005 at 11:34:14AM +0200, Ruslan Ermilov wrote: > > > On Mon, Feb 28, 2005 at 09:23:38AM +0000, David E. O'Brien wrote: > > > > obrien 2005-02-28 09:23:38 UTC > > > >=20 > > > > FreeBSD src repository > > > >=20 > > > > Modified files: > > > > . Makefile.inc1=20 > > > > share/mk bsd.compat.mk=20 > > > > Log: > > > > Accept the old user interface for NO_CLEAN as it is a POLA violat= ion as > > > > we've eventually changed the user interface of a common command. > > > > =20 > > > > Revision Changes Path > > > > 1.486 +3 -0 src/Makefile.inc1 > > > > 1.19 +0 -1 src/share/mk/bsd.compat.mk > > > >=20 > > > Why did you do this? bsd.compat.mk already handled this, and > > > Makefile.inc1 is always called with ``-m /usr/src/share/mk''. > > > Even if you call Makefile.inc1 directly, and your /usr/share/mk > > > is up-to-date, you'll get a warning and setting. Would you > > > please revert this change? > > >=20 > > Or maybe I misunderstood you, and you just wanted it to be quiet? > > Even so, please handle it all in bsd.compat.mk. >=20 > Looking at bsd.compat.mk, especially with "BURN_BRIDGES" in there; I'd > like to ask you for a patch you'd be happy with that isn't going away in > a few months when the bridges burn. A correct patch will have to add > another layer of .if statements in the case of "NOCLEAN". > =20 First tell me what you were trying to achieve with this change, as I cannot intuit it from your commit log, and you don't tell me. :-) Let me explain. "make ... -DNOCLEAN" worked before it, replacing it with NO_CLEAN and giving an annoying warning, so burning bridges later won't be a surprise. If you thought it wasn't working, then please re-test and consider reverting your change. If you are just hiding the warning, can you explain your reasoning, as in my opinion it just kills the idea of "deprecation". People will continue to use it, without letting us remove it safely later. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --2oS5YaxWCcQjTEyO Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFCI5BJqRfpzJluFF4RAvzoAJ9aOvb2UWOt5GXFY0RpMEmnDMs76ACbBg40 JQsHmIpdR0zf9F6xp4lGE88= =s8ds -----END PGP SIGNATURE----- --2oS5YaxWCcQjTEyO--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050228214233.GA6011>