Date: Sun, 26 Jun 2005 13:00:26 -0700 From: Eric Anholt <eta@lclark.edu> To: Martin Cracauer <cracauer@cons.org> Cc: freebsd-current@freebsd.org, Adam K Kirchhoff <adamk@voicenet.com>, Warner Losh <imp@bsdimp.com> Subject: Re: 6.0-current panic: loading radeon module Message-ID: <1119816026.3817.20.camel@leguin> In-Reply-To: <20050624195906.A5702@cons.org> References: <20050617173008.A11142@cons.org> <20050617194638.A13394@cons.org> <20050617.233055.41723867.imp@bsdimp.com> <200506241641.25433.jhb@FreeBSD.org> <1119650444.1173.105.camel@leguin> <20050624195906.A5702@cons.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-vcJVV1B5Ja3tWfs1ztSH Content-Type: text/plain Content-Transfer-Encoding: 7bit On Fri, 2005-06-24 at 19:59 -0400, Martin Cracauer wrote: > > I'd forgotten about this thread. I've got a proposed fix for this at: > > http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/80718 > > I get the same panic and backtrace with that patch (on a 32 MB moobile > Radeon 7500). > > I will annotate the sourcecode now to verify (or not) the NULLs in the > arguments for the bus argument. OK, one more try, for everyone who's been having hangs/reboots on X startup since April. Attached is a patch that will hopefully kill the problem off. -- Eric Anholt eta@lclark.edu http://people.freebsd.org/~anholt/ anholt@FreeBSD.org --=-vcJVV1B5Ja3tWfs1ztSH Content-Disposition: attachment; filename=drm-initmap-mapping-2.diff Content-Type: text/x-patch; name=drm-initmap-mapping-2.diff; charset=ISO-8859-1 Content-Transfer-Encoding: base64 SW5kZXg6IGRldi9kcm0vZHJtUC5oDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmlsZTogL2hvbWUvbmN2cy9z cmMvc3lzL2Rldi9kcm0vZHJtUC5oLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4xMw0KZGlmZiAt dSAtcjEuMTMgZHJtUC5oDQotLS0gZGV2L2RybS9kcm1QLmgJMTYgQXByIDIwMDUgMDM6NDQ6NDMg LTAwMDAJMS4xMw0KKysrIGRldi9kcm0vZHJtUC5oCTI2IEp1biAyMDA1IDE5OjIxOjE5IC0wMDAw DQpAQCAtNzcsNiArNzcsNyBAQA0KICNpZiBfX0ZyZWVCU0RfdmVyc2lvbiA+PSA1MDAwMDANCiAj aW5jbHVkZSA8c3lzL211dGV4Lmg+DQogI2luY2x1ZGUgPGRldi9wY2kvcGNpdmFyLmg+DQorI2lu Y2x1ZGUgPGRldi9wY2kvcGNpcmVnLmg+DQogI2luY2x1ZGUgPHN5cy9zZWxpbmZvLmg+DQogI2Vs c2UgLyogX19GcmVlQlNEX3ZlcnNpb24gPj0gNTAwMDAwICovDQogI2luY2x1ZGUgPHBjaS9wY2l2 YXIuaD4NCkluZGV4OiBkZXYvZHJtL2RybV9idWZzLmMNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAv aG9tZS9uY3ZzL3NyYy9zeXMvZGV2L2RybS9kcm1fYnVmcy5jLHYNCnJldHJpZXZpbmcgcmV2aXNp b24gMS4yDQpkaWZmIC11IC1yMS4yIGRybV9idWZzLmMNCi0tLSBkZXYvZHJtL2RybV9idWZzLmMJ MjQgQXByIDIwMDUgMTk6MDM6MzIgLTAwMDAJMS4yDQorKysgZGV2L2RybS9kcm1fYnVmcy5jCTI2 IEp1biAyMDA1IDE5OjQ1OjQwIC0wMDAwDQpAQCAtNTIsNDMgKzUyLDMzIEBADQogDQogdW5zaWdu ZWQgbG9uZyBkcm1fZ2V0X3Jlc291cmNlX3N0YXJ0KGRybV9kZXZpY2VfdCAqZGV2LCB1bnNpZ25l ZCBpbnQgcmVzb3VyY2UpDQogew0KLQlzdHJ1Y3QgcmVzb3VyY2UgKmJzcjsNCiAJdW5zaWduZWQg bG9uZyBvZmZzZXQ7DQorCXVuc2lnbmVkIGxvbmcgbGVuOw0KKwlpbnQgZXJyOw0KIA0KLQlyZXNv dXJjZSA9IHJlc291cmNlICogNCArIDB4MTA7DQotDQotCWJzciA9IGJ1c19hbGxvY19yZXNvdXJj ZV9hbnkoZGV2LT5kZXZpY2UsIFNZU19SRVNfTUVNT1JZLCAmcmVzb3VyY2UsDQotCSAgICBSRl9B Q1RJVkUgfCBSRl9TSEFSRUFCTEUpOw0KLQlpZiAoYnNyID09IE5VTEwpIHsNCi0JCURSTV9FUlJP UigiQ291bGRuJ3QgZmluZCByZXNvdXJjZSAweCV4XG4iLCByZXNvdXJjZSk7DQorCWVyciA9IGJ1 c19nZXRfcmVzb3VyY2UoZGV2LT5kZXZpY2UsIFNZU19SRVNfTUVNT1JZLCBQQ0lSX0JBUihyZXNv dXJjZSksDQorCSAgICAmb2Zmc2V0LCAmbGVuKTsNCisJaWYgKGVyciAhPSAwKSB7DQorCQlEUk1f RVJST1IoIkZhaWxlZCB0byBnZXQgc3RhcnQgb2YgcmVzb3VyY2UgMHgleFxuIiwgcmVzb3VyY2Up Ow0KIAkJcmV0dXJuIDA7DQogCX0NCiANCi0Jb2Zmc2V0ID0gcm1hbl9nZXRfc3RhcnQoYnNyKTsN Ci0NCi0JYnVzX3JlbGVhc2VfcmVzb3VyY2UoZGV2LT5kZXZpY2UsIFNZU19SRVNfTUVNT1JZLCBy ZXNvdXJjZSwgYnNyKTsNCi0NCiAJcmV0dXJuIG9mZnNldDsNCiB9DQogDQogdW5zaWduZWQgbG9u ZyBkcm1fZ2V0X3Jlc291cmNlX2xlbihkcm1fZGV2aWNlX3QgKmRldiwgdW5zaWduZWQgaW50IHJl c291cmNlKQ0KIHsNCi0Jc3RydWN0IHJlc291cmNlICpic3I7DQorCXVuc2lnbmVkIGxvbmcgb2Zm c2V0Ow0KIAl1bnNpZ25lZCBsb25nIGxlbjsNCisJaW50IGVycjsNCiANCi0JcmVzb3VyY2UgPSBy ZXNvdXJjZSAqIDQgKyAweDEwOw0KLQ0KLQlic3IgPSBidXNfYWxsb2NfcmVzb3VyY2VfYW55KGRl di0+ZGV2aWNlLCBTWVNfUkVTX01FTU9SWSwgJnJlc291cmNlLA0KLQkgICAgUkZfQUNUSVZFIHwg UkZfU0hBUkVBQkxFKTsNCi0JaWYgKGJzciA9PSBOVUxMKSB7DQotCQlEUk1fRVJST1IoIkNvdWxk bid0IGZpbmQgcmVzb3VyY2UgMHgleFxuIiwgcmVzb3VyY2UpOw0KLQkJcmV0dXJuIEVOT01FTTsN CisJZXJyID0gYnVzX2dldF9yZXNvdXJjZShkZXYtPmRldmljZSwgU1lTX1JFU19NRU1PUlksIFBD SVJfQkFSKHJlc291cmNlKSwNCisJICAgICZvZmZzZXQsICZsZW4pOw0KKwlpZiAoZXJyICE9IDAp IHsNCisJCURSTV9FUlJPUigiRmFpbGVkIHRvIGdldCBsZW5ndGggb2YgcmVzb3VyY2UgMHgleFxu IiwgcmVzb3VyY2UpOw0KKwkJcmV0dXJuIDA7DQogCX0NCiANCi0JbGVuID0gcm1hbl9nZXRfc2l6 ZShic3IpOw0KLQ0KLQlidXNfcmVsZWFzZV9yZXNvdXJjZShkZXYtPmRldmljZSwgU1lTX1JFU19N RU1PUlksIHJlc291cmNlLCBic3IpOw0KLQ0KIAlyZXR1cm4gbGVuOw0KIH0NCiANCkBAIC05Niw3 ICs4Niw2IEBADQogCQl1bnNpZ25lZCBpbnQgcmVzb3VyY2UsIGludCB0eXBlLCBpbnQgZmxhZ3Mp DQogew0KIAlkcm1fbG9jYWxfbWFwX3QgKm1hcDsNCi0Jc3RydWN0IHJlc291cmNlICpic3I7DQog DQogCWlmICh0eXBlICE9IF9EUk1fUkVHSVNURVJTICYmIHR5cGUgIT0gX0RSTV9GUkFNRV9CVUZG RVIpDQogCQlyZXR1cm4gRUlOVkFMOw0KQEAgLTEwNywyOCArOTYsMjkgQEANCiAJaWYgKG1hcCA9 PSBOVUxMKQ0KIAkJcmV0dXJuIEVOT01FTTsNCiANCi0JbWFwLT5yaWQgPSByZXNvdXJjZSAqIDQg KyAweDEwOw0KLQlic3IgPSBidXNfYWxsb2NfcmVzb3VyY2VfYW55KGRldi0+ZGV2aWNlLCBTWVNf UkVTX01FTU9SWSwgJm1hcC0+cmlkLA0KLQkgICAgUkZfQUNUSVZFIHwgUkZfU0hBUkVBQkxFKTsN Ci0JaWYgKGJzciA9PSBOVUxMKSB7DQotCQlEUk1fRVJST1IoIkNvdWxkbid0IGFsbG9jYXRlICVz IHJlc291cmNlXG4iLA0KLQkJICAgICgodHlwZSA9PSBfRFJNX1JFR0lTVEVSUykgPyAibW1pbyIg OiAiZnJhbWVidWZmZXIiKSk7DQotCQlmcmVlKG1hcCwgTV9EUk0pOw0KLQkJcmV0dXJuIEVOT01F TTsNCisJaWYgKHR5cGUgPT0gX0RSTV9SRUdJU1RFUlMpIHsNCisJCXN0cnVjdCByZXNvdXJjZSAq YnNyOw0KKwkJbWFwLT5yaWQgPSByZXNvdXJjZSAqIDQgKyAweDEwOw0KKwkJYnNyID0gYnVzX2Fs bG9jX3Jlc291cmNlX2FueShkZXYtPmRldmljZSwgU1lTX1JFU19NRU1PUlksDQorCQkgICAgJm1h cC0+cmlkLCBSRl9BQ1RJVkUgfCBSRl9TSEFSRUFCTEUpOw0KKwkJaWYgKGJzciA9PSBOVUxMKSB7 DQorCQkJRFJNX0VSUk9SKCJDb3VsZG4ndCBhbGxvY2F0ZSAlcyByZXNvdXJjZVxuIiwNCisJCQkg ICAgKCh0eXBlID09IF9EUk1fUkVHSVNURVJTKSA/ICJtbWlvIiA6ICJmcmFtZWJ1ZmZlciIpKTsN CisJCQlmcmVlKG1hcCwgTV9EUk0pOw0KKwkJCXJldHVybiBFTk9NRU07DQorCQl9DQorCQltYXAt PmJzciA9IGJzcjsNCisJCW1hcC0+YnN0ID0gcm1hbl9nZXRfYnVzdGFnKGJzcik7DQorCQltYXAt PmJzaCA9IHJtYW5fZ2V0X2J1c2hhbmRsZShic3IpOw0KKwkJbWFwLT5oYW5kbGUgPSBybWFuX2dl dF92aXJ0dWFsKGJzcik7DQogCX0NCiANCiAJbWFwLT5rZXJuZWxfb3duZWQgPSAxOw0KIAltYXAt PnR5cGUgPSB0eXBlOw0KIAltYXAtPmZsYWdzID0gZmxhZ3M7DQotCW1hcC0+YnNyID0gYnNyOw0K LQltYXAtPmJzdCA9IHJtYW5fZ2V0X2J1c3RhZyhic3IpOw0KLQltYXAtPmJzaCA9IHJtYW5fZ2V0 X2J1c2hhbmRsZShic3IpOw0KIAltYXAtPm9mZnNldCA9IHN0YXJ0Ow0KIAltYXAtPnNpemUgPSBs ZW47DQogDQotCWlmICh0eXBlID09IF9EUk1fUkVHSVNURVJTKQ0KLQkJbWFwLT5oYW5kbGUgPSBy bWFuX2dldF92aXJ0dWFsKGJzcik7DQotDQogCURSTV9ERUJVRygiaW5pdG1hcCAlZCwweCV4QDB4 JWx4LzB4JWx4XG4iLCBtYXAtPnR5cGUsIG1hcC0+ZmxhZ3MsDQogCSAgICBtYXAtPm9mZnNldCwg bWFwLT5zaXplKTsNCiANCg== --=-vcJVV1B5Ja3tWfs1ztSH--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1119816026.3817.20.camel>