Date: Sun, 26 Jan 2014 17:18:39 -0200 From: Renato Botelho <garga@FreeBSD.org> To: Andrej Zverev <az@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>, Martin Wilke <miwi@freebsd.org> Subject: Re: svn commit: r341219 - in head/www: xpi-twitterfox xpi-unplug xpi-urllink xpi-user_agent_switcher xpi-vimperator Message-ID: <52E55F8F.2080305@FreeBSD.org> In-Reply-To: <CAD5bB%2BhV%2Bmrp_%2B%2BnEWjzAo=qVgw2L0sMgGHb4=zqzEEMdQu6nw@mail.gmail.com> References: <201401261514.s0QFEZY7093314@svn.freebsd.org> <CAD5bB%2BgSAO4BFGpCTgC7HiOTxT6i2fwgmtbxupmHVgR5tWEQJQ@mail.gmail.com> <52E54E98.8080307@FreeBSD.org> <CAD5bB%2BhV%2Bmrp_%2B%2BnEWjzAo=qVgw2L0sMgGHb4=zqzEEMdQu6nw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ifdJ2MOUKFxvXHIEbcjsIXdnPRi0O3Cbm Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 26-01-2014 17:14, Andrej Zverev wrote: > On Sun, Jan 26, 2014 at 10:06 PM, Renato Botelho <garga@freebsd.org> wr= ote: >> On 26-01-2014 13:23, Andrej Zverev wrote: >>> On Sun, Jan 26, 2014 at 7:14 PM, Martin Wilke <miwi@freebsd.org> wrot= e: >>>> Author: miwi >>>> Date: Sun Jan 26 15:14:34 2014 >>>> New Revision: 341219 >>>> URL: http://svnweb.freebsd.org/changeset/ports/341219 >>>> QAT: https://qat.redports.org/buildarchive/r341219/ >>>> >>>> Log: >>>> - Stage support >>>> >>>> >>>> Modified: head/www/xpi-unplug/Makefile >>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>>> --- head/www/xpi-unplug/Makefile Sun Jan 26 15:14:03 2014 = (r341218) >>>> +++ head/www/xpi-unplug/Makefile Sun Jan 26 15:14:34 2014 = (r341219) >>>> @@ -12,7 +12,6 @@ COMMENT=3D Converts embedded media to html >>>> XPI_ID=3D unplug@compunach >>>> XPI_NUM=3D 2254 >>>> >>>> -NO_STAGE=3D yes >>>> xpi-post-extract: >>>> ${FIND} ${WRKSRC} -type d -name CVS|${XARGS} ${RM} -rf >>>> >>>> >>>> Modified: head/www/xpi-urllink/Makefile >>> >>> >>> Can you at least run portlint and fix easy warnings in such commits? = like >>> "WARN: Makefile: [17]: possible use of "${FIND} ... ${XARGS} ${RM}" >>> when "${FIND} ... -delete" will work" >> >> find -delete won't delete a not empty directory. And this find is only= >> looking for directories. >=20 > While this is true, but distfile itself does not contain any CVS > directories in this case ;-) > 'easy fix' Now you have a good point :) --=20 Renato Botelho <garga @ FreeBSD.org> <garga.bsd @ gmail.com> GnuPG Key: http://www.FreeBSD.org/~garga/pubkey.asc --ifdJ2MOUKFxvXHIEbcjsIXdnPRi0O3Cbm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCgAGBQJS5V+PAAoJEPHw56GfYleQYCUP/iLfEWtQk3JiMBmNcSdnvX+D hLLjFP51pZnVOrebzv6lf+s04hubDQKM1lL0gOTwGQFIVDQMI93218NJXzoVhqqC Ws8s8qxlod0J7Gm2ndqojF5HnGb7J6hRU/8oj0T+xfgnddKQOJhuWsAXY4ZyNOf3 HhFgMWSfNdILEuELrYz+ynHR2T6WaJw69Hh5c7Whq+GK8y85MAgWkWJLjEnh4QHz Rpcv+/8TKUEGBHdj1hEVONk2RdD3mp1A1anLNQriRnc3THFeX03hsc8/2EgreCBk 2l4dltfiIH/0Z3hhoIewKjAGkIZJ97TZrjH8Qc2EY3xqaq7+dSnt9sYSKo5ouIlt cnEwC6wP82yCewObEC5wZKWm8NH7lMeZomoxImsQObc0M4MikMEBC2LFLW8zRBWj xKbCn9lLERn5xaOQ3lxRACcH7cN+Mdwl+6y8ZDP6l+iA5Toe6p9BUuvAKSk8VoEE e+K+6y6X9biVyyTcMFBB0QMVujSZhr2ZwJlidhy7QLm6w+GcWmlBaqsn5TF319zb ivXPSxjM0uKm+qY7gwQC42VlY+LoEkqBtewFR3KGp+PY/CchZjaGLYSkqVWVMYzM +xIXNxWZSCu5g0SXAEQuaGfBaGUBw87xK14H3ahctw3A2D+A/dpcU0bPR95OLgZQ kQI5o9XQogrW3RlyZYCn =0kBo -----END PGP SIGNATURE----- --ifdJ2MOUKFxvXHIEbcjsIXdnPRi0O3Cbm--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52E55F8F.2080305>