Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 22 Sep 2009 22:58:10 +0200
From:      Pawel Jakub Dawidek <pjd@FreeBSD.org>
To:        John Baldwin <jhb@freebsd.org>
Cc:        svn-src-head@freebsd.org, Roman Divacky <rdivacky@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org
Subject:   Re: svn commit: r197408 - in head/sys: conf ufs/ufs
Message-ID:  <20090922205809.GB2970@garage.freebsd.pl>
In-Reply-To: <200909221301.07781.jhb@freebsd.org>
References:  <200909221622.n8MGM5WK025136@svn.freebsd.org> <200909221301.07781.jhb@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--ew6BAiZeqk4r7MaW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Sep 22, 2009 at 01:01:07PM -0400, John Baldwin wrote:
> On Tuesday 22 September 2009 12:22:05 pm Roman Divacky wrote:
> > Author: rdivacky
> > Date: Tue Sep 22 16:22:05 2009
> > New Revision: 197408
> > URL: http://svn.freebsd.org/changeset/base/197408
> >=20
> > Log:
> >   Don't build ufs_gjournal.c at all if UFS_GJOURNAL option is not given
> >   instead of building an almost empty C file.
> >  =20
> >   Approved by:	pjd
> >   Approved by:	ed (mentor, implicit)
> >=20
> > Modified:
> >   head/sys/conf/files
> >   head/sys/ufs/ufs/ufs_gjournal.c
> >=20
> > Modified: head/sys/conf/files
> >=20
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> > --- head/sys/conf/files	Tue Sep 22 16:16:02 2009	(r197407)
> > +++ head/sys/conf/files	Tue Sep 22 16:22:05 2009	(r197408)
> > @@ -2634,7 +2634,7 @@ ufs/ufs/ufs_acl.c		optional ffs
> >  ufs/ufs/ufs_bmap.c		optional ffs
> >  ufs/ufs/ufs_dirhash.c		optional ffs
> >  ufs/ufs/ufs_extattr.c		optional ffs
> > -ufs/ufs/ufs_gjournal.c		optional ffs
> > +ufs/ufs/ufs_gjournal.c		optional ffs UFS_GJOURNAL
> >  ufs/ufs/ufs_inode.c		optional ffs
> >  ufs/ufs/ufs_lookup.c		optional ffs
> >  ufs/ufs/ufs_quota.c		optional ffs
>=20
> Hmm, shouldn't this be lowercase?

That was my comment to the patch...

--=20
Pawel Jakub Dawidek                       http://www.wheel.pl
pjd@FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!

--ew6BAiZeqk4r7MaW
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4 (FreeBSD)

iD8DBQFKuTphForvXbEpPzQRAiJxAKDMRl5apNxxJYB0g2fe7kBH9wwDsQCfb+GD
BOkLsNIjGBGIfA3DurVAYH4=
=tG3f
-----END PGP SIGNATURE-----

--ew6BAiZeqk4r7MaW--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090922205809.GB2970>