Date: Wed, 26 Sep 2007 10:48:10 -0400 From: John Baldwin <jhb@freebsd.org> To: Roman Divacky <rdivacky@freebsd.org> Cc: Jesper Brix Rosenkilde <jbr@freebsd.org>, Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 125372 for review Message-ID: <200709261048.11221.jhb@freebsd.org> In-Reply-To: <20070820091136.GA47764@freebsd.org> References: <200708200201.l7K21c3v034586@repoman.freebsd.org> <20070820091136.GA47764@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 20 August 2007 05:11:36 am Roman Divacky wrote: > > + PROC_LOCK(p); > > outsysshm.pid = p->p_pid; > > - strncpy(outsysshm.progtitle, p->p_comm, MAXCOMLEN); > > - strncpy(outsysshm.proctitle, "\0", 1); > > - copyout((caddr_t) &outsysshm, (caddr_t) *addr, sizeof(struct sysshm)); > > + copyout(&outsysshm, (vm_offset_t *) p->p_usrsysshm, > > + sizeof(struct sysshm)); > > + PROC_UNLOCK(p); > > I dont think you can copyout while holding proc lock. Correct, but as per my earlier e-mail, the locking isn't needed anyway. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200709261048.11221.jhb>