Date: Tue, 28 May 2002 21:25:01 +0900 (KST)
From: CHOI Junho <cjh@kr.FreeBSD.org>
To: imura@ryu16.org
Cc: kris@obsecurity.org, sobomax@freebsd.org, ports@freebsd.org, ports-jp@jp.FreeBSD.org
Subject: Re: {korean,japanese}/msdosfs
Message-ID: <20020528.212501.48538641.cjh@kr.FreeBSD.org>
In-Reply-To: <20020525060232.B6222@ryu16.org>
References: <20020523223446.A10172@xor.obsecurity.org> <20020524.144243.27837647.cjh@kr.FreeBSD.org> <20020525060232.B6222@ryu16.org>
next in thread | previous in thread | raw e-mail | index | archive | help
----Next_Part(Tue_May_28_21:25:02_2002_876)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Ok, I attached the diff not to use kldload. If you have no objection,
I'll commit it tomorrow. I think information message is not necessary,
because it already mention about $PREFIX/etc/rc.d/{ja,ko}-msdosfs.sh
start script.
Thanks!
From: "R. Imura" <imura@ryu16.org>
Subject: Re: {korean,japanese}/msdosfs
Date: Sat, 25 May 2002 06:02:32 +0900
> Hi,
>
> On Fri, May 24, 2002 at 02:42:43PM +0900, CHOI Junho wrote:
> > > Yes, but why is it required that the kernel support mounting msdosfs
> > > partitions in order to install or create the package? I don't see why
> > > the kldload operation is necessary.
> >
> > To automatically loading this module - I think it is just for the
> > convenience of users, to load .ko without calling start script in
> > ${PREFIX}/etc/rc.d. But it's unnecessary...
>
> Yes, it's just for the convenience of users, especially for the beginners.
>
> > If the owner of japanese/msdosfs agree, I'll change it not to load
> > .ko in pkg-plist or post-install.
>
> I agree, I'm not the owner anymore nor one of users though.
> I would appreciate it if you could change ja-msdosfs as well as
> the korean version.
>
> Regards,
>
> - R. Imura -- too old maintainer
--
+++ Any opinions in this posting are my own and not those of my employers +++
CHOI Junho [sleeping now] <http://www.kr.FreeBSD.org/~cjh>;
[while sleeping] <cjh @ kr.FreeBSD.ORG> <cjh @ FreeBSD.ORG> <cjh @ wdb.co.kr>
Korea FreeBSD Users Group <www.kr.FreeBSD.org> Web Data Bank<www.wdb.co.kr>
----Next_Part(Tue_May_28_21:25:02_2002_876)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline; filename="ja-ko-msdosfs.diff"
diff -cNr korean/m/Makefile korean/msdosfs/Makefile
*** korean/m/Makefile Tue May 28 20:58:56 2002
--- korean/msdosfs/Makefile Tue May 28 20:59:33 2002
***************
*** 63,69 ****
${INSTALL_SCRIPT} ${WRKSRC}/msdos_ko.ko ${PREFIX}/lib/ko-msdosfs
${INSTALL_SCRIPT} ${WRKDIR}/ko-msdosfs.sh ${PREFIX}/etc/rc.d
- post-install:
- /sbin/kldload ${PREFIX}/lib/ko-msdosfs/msdos_ko.ko
-
.include <bsd.port.post.mk>
--- 63,66 ----
diff -cNr korean/m/pkg-plist korean/msdosfs/pkg-plist
*** korean/m/pkg-plist Tue May 28 20:58:56 2002
--- korean/msdosfs/pkg-plist Tue May 28 21:03:52 2002
***************
*** 1,6 ****
etc/rc.d/ko-msdosfs.sh
lib/ko-msdosfs/msdos_ko.ko
sbin/mount_komsdos
@dirrm lib/ko-msdosfs
- @exec /sbin/kldload %D/lib/ko-msdosfs/msdos_ko.ko
- @unexec /sbin/kldunload msdos_ko 2>/dev/null || /usr/bin/true
--- 1,5 ----
etc/rc.d/ko-msdosfs.sh
+ @unexec /sbin/kldunload msdos_ko 2>/dev/null || /usr/bin/true
lib/ko-msdosfs/msdos_ko.ko
sbin/mount_komsdos
@dirrm lib/ko-msdosfs
diff -cNr japanese/m/Makefile japanese/msdosfs/Makefile
*** japanese/m/Makefile Tue May 28 21:05:02 2002
--- japanese/msdosfs/Makefile Tue May 28 21:03:10 2002
***************
*** 60,66 ****
${INSTALL_SCRIPT} ${WRKSRC}/msdos_ja.ko ${PREFIX}/lib/ja-msdosfs
${INSTALL_SCRIPT} ${WRKDIR}/ja-msdosfs.sh ${PREFIX}/etc/rc.d
- post-install:
- /sbin/kldload ${PREFIX}/lib/ja-msdosfs/msdos_ja.ko
-
.include <bsd.port.post.mk>
--- 60,63 ----
diff -cNr japanese/m/pkg-plist japanese/msdosfs/pkg-plist
*** japanese/m/pkg-plist Tue May 28 21:05:02 2002
--- japanese/msdosfs/pkg-plist Tue May 28 21:03:41 2002
***************
*** 1,6 ****
etc/rc.d/ja-msdosfs.sh
lib/ja-msdosfs/msdos_ja.ko
sbin/mount_jamsdos
@dirrm lib/ja-msdosfs
- @exec /sbin/kldload %D/lib/ja-msdosfs/msdos_ja.ko
- @unexec /sbin/kldunload msdos_ja 2>/dev/null || /usr/bin/true
--- 1,5 ----
etc/rc.d/ja-msdosfs.sh
+ @unexec /sbin/kldunload msdos_ja 2>/dev/null || /usr/bin/true
lib/ja-msdosfs/msdos_ja.ko
sbin/mount_jamsdos
@dirrm lib/ja-msdosfs
----Next_Part(Tue_May_28_21:25:02_2002_876)----
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020528.212501.48538641.cjh>