Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 3 Dec 1998 19:46:51 -0800 (PST)
From:      Matthew Dillon <dillon@apollo.backplane.com>
To:        "Andrey A. Chernov" <ache@nagual.pp.ru>
Cc:        cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject:   Re: cvs commit: src/sys/netinet icmp_var.h ip_icmp.c tcp_input.c udp_usrreq.c
Message-ID:  <199812040346.TAA02228@apollo.backplane.com>
References:  <199812032023.MAA02215@freefall.freebsd.org> <19981204064311.A31118@nagual.pp.ru>

next in thread | previous in thread | raw e-mail | index | archive | help
:On Thu, Dec 03, 1998 at 12:23:21PM -0800, Matt Dillon wrote:
:> dillon      1998/12/03 12:23:21 PST
:> 
:>   Modified files:
:>     sys/netinet          icmp_var.h ip_icmp.c tcp_input.c 
:>                          udp_usrreq.c 
:
:Please remove or #ifdef KERNEL
:#include "opt_icmp_bandlim.h"
:from icmp_var.h, this file sometimes used in userland applications which
:are broken now.
:Function badport_badlim should also be removed of KERNEL #ifdefed.
:
:Basically I dislike idea of touching icmp_var.h at all, could you add
:separate include file for this stuff, please?

    I'll add the #ifdef KERNEL.  I'd gladly move everything out of
    icmp_var.h if you tell me how to deal with the sysctl initialization 
    (can I just use the AUTO mode and get rid of the ICMPCTL_MAXID and 
    ICMP_BANDLI<_INFO junk?) and where to put the badport_bandlim() extern.

					    -Matt
:-- 
:Andrey A. Chernov
:http://www.nagual.pp.ru/~ache/
:MTH/SH/HE S-- W-- N+ PEC>+ D A a++ C G>+ QH+(++) 666+>++ Y
:
:

    Matthew Dillon  Engineering, HiWay Technologies, Inc. & BEST Internet 
                    Communications & God knows what else.
    <dillon@backplane.com> (Please include original email in any response)    

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199812040346.TAA02228>