Date: Fri, 16 Jul 2010 14:52:35 -0400 From: Jung-uk Kim <jkim@FreeBSD.org> To: freebsd-stable@FreeBSD.org Cc: Oliver Fromme <olli@lurza.secnetix.de>, Andriy Gapon <avg@icyb.net.ua>, Jeremy Chadwick <freebsd@jdc.parodius.com> Subject: Re: 8.1-PRERELEASE: CPU packages not detected correctly Message-ID: <201007161452.37538.jkim@FreeBSD.org> In-Reply-To: <20100716075525.GA96403@icarus.home.lan> References: <201007151507.33998.jkim@FreeBSD.org> <201007152001.o6FK1mGq088944@lurza.secnetix.de> <20100716075525.GA96403@icarus.home.lan>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 16 July 2010 03:55 am, Jeremy Chadwick wrote: > On Thu, Jul 15, 2010 at 10:01:48PM +0200, Oliver Fromme wrote: > > Jung-uk Kim wrote: > > > On Thursday 15 July 2010 01:56 pm, Andriy Gapon wrote: > > > > on 15/07/2010 19:57 Oliver Fromme said the following: > > > > > I patched topo_probe() so it calls topo_probe_0x4() after > > > > > topo_probe_0xb() if cpu_cores is still 0. I think this > > > > > is a better fallback procedure. With this patch, > > > > > cpu_cores gets the value 4 which is the correct one, > > > > > finally: > > > > > > > > [...] > > > > I think that your addition achieves this effect, perhaps > > > > just not as explicitly as I would preferred. > > > > > > > > Jung-uk, what do you think? > > > > > > Yes, you're right. Please try new patch: > > > > > > http://people.freebsd.org/~jkim/mp_machdep2.diff > > > > Thank you! > > > > I will have access to that particular machine on Monday again, > > so testing the new patch will have to wait until Monday. > > But from looking at your patch it should have the same result > > as my simpler patch, so it should work fine. > > I have a general question for everyone involved in this thread > (which is highly educational/interesting -- thank you for all the > info!): > > Does the problem reported affect actual performance/behaviour of > FreeBSD kernel-wise at all, or is it just a cosmetical issue with > regards to showing how many cores/threads there are? Theoretically there is behavioral changes from scheduler. jeff@ should be able to tell you more about this. Jung-uk Kim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201007161452.37538.jkim>