Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 1 Feb 2001 02:56:22 +0200 (IST)
From:      roman@xpert.com
To:        FreeBSD-gnats-submit@freebsd.org, ache@freebsd.org
Subject:   ports/24766: [PATCH] fix archivers/unarj - now it creates directories
Message-ID:  <200102010056.f110uMK55371@alchemy.oven.org>

next in thread | raw e-mail | index | archive | help

>Number:         24766
>Category:       ports
>Synopsis:       [PATCH] fix archivers/unarj - now it creates directories
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 31 17:00:01 PST 2001
>Closed-Date:
>Last-Modified:
>Originator:     Roman Shterenzon
>Release:        FreeBSD 4.2-STABLE i386
>Organization:
>Environment:


>Description:

The shipping unarj doesn't create directories stored in arj archives.
That makes it almost unusable.
The attached patch is a patch from RedHat which is used from August 2000 and
until today and does its job well.
Please add it to the unarj port.

>How-To-Repeat:

create arj archive with stored subdirs, try to unpack it in FreeBSD.

>Fix:

diff -urN unarj-2.43/unarj.c unarj-2.43.new/unarj.c
--- unarj.c.orig	Mon Sep 29 14:00:24 1997
+++ unarj.c	Tue Aug  8 15:57:58 2000
@@ -42,7 +42,8 @@
  * 02/17/93  R. Jung     Added archive modified date support.
  * 01/22/94  R. Jung     Changed copyright message.
  * 07/29/96  R. Jung     Added "/" to list of path separators.
- *
+ * 08/08/00  P. Knirsch  Added subdirectory creation for the x command. Also
+ *                       fixed some compiler warnings.
  */
 
 #include "unarj.h"
@@ -51,6 +52,10 @@
 #include <stdlib.h>
 #include <string.h>
 #include <ctype.h>
+#include <sys/stat.h>
+#include <sys/types.h>
+#include <fcntl.h>
+#include <unistd.h>
 #else /* !MODERN */
 extern void free();
 extern void exit();
@@ -712,6 +717,8 @@
 extract()
 {
     char name[FNAME_MAX];
+    char dir[FNAME_MAX];
+    char *pos;
 
     if (check_flags())
     {
@@ -730,6 +737,21 @@
 
     if (host_os != OS)
         default_case_path(name);
+
+
+    /*
+       8/8/2000 Phil Knirsch: Bugfix to create subdirectories. Unarj didn't
+       do this for a long time, so it's finally fixed.
+    */
+    pos = strchr(name, PATH_CHAR);
+
+    while (pos != NULL)
+    {
+        strncpy(dir, name, pos-name);
+        dir[pos-name] = '\0';
+        mkdir(dir, 0777);
+        pos = strchr(pos+1, PATH_CHAR);
+    }
 
     if (file_exists(name))
     {

>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200102010056.f110uMK55371>