Date: Fri, 4 Dec 1998 07:13:57 +0300 From: "Andrey A. Chernov" <ache@nagual.pp.ru> To: Matt Dillon <dillon@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/netinet icmp_var.h Message-ID: <19981204071357.A41880@nagual.pp.ru> In-Reply-To: <19981204070811.A40154@nagual.pp.ru>; from ache@nagual.pp.ru on Fri, Dec 04, 1998 at 07:08:11AM %2B0300 References: <199812040349.TAA22636@freefall.freebsd.org> <19981204070811.A40154@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Dec 04, 1998 at 07:08:11AM +0300, Andrey A. Chernov wrote: > On Thu, Dec 03, 1998 at 07:49:19PM -0800, Matt Dillon wrote: > > dillon 1998/12/03 19:49:18 PST > > Quick add #ifdef KERNEL for ICMP_BANDLIM option so userland program > > can #include icmp_var.h > > badport_badlim should be #ifdef'ed KERNEL too to prevent name pollution. > No user-visible stuff should depend on ICMP_BANDLIM option, it is legal > name and can be used by user freely. No optional compilation of this user > header file allowed, it means you need to make BANDLIM sysctl always > visible and get rid of ICMP_BANDLIM option from sysctl definition too. See > my previous message on this subject. Just to add: if you get rid of ICMP_BANDLIM option from this header file, you can remove opt_icmp_bandlim.h from it too! I assume you later include opt_icmp_bandlim.h in kernel *.c files which really need it, it is better variant because now too many files will be recompiled if BANDLIM option changed. -- Andrey A. Chernov http://www.nagual.pp.ru/~ache/ MTH/SH/HE S-- W-- N+ PEC>+ D A a++ C G>+ QH+(++) 666+>++ Y To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19981204071357.A41880>