Date: Wed, 10 Mar 2010 18:29:47 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Martin Wilke <miwi@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net-mgmt/rackmonkey Makefile Message-ID: <20100310182947.GA75413@FreeBSD.org> In-Reply-To: <201003101753.o2AHrRLT099735@repoman.freebsd.org> References: <201003101753.o2AHrRLT099735@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 10, 2010 at 05:53:27PM +0000, Martin Wilke wrote: > miwi 2010-03-10 17:53:27 UTC > > FreeBSD ports repository > > Modified files: > net-mgmt/rackmonkey Makefile > Log: > - Add missing dependency It is good that you've reindented OPTIONS, but it would be nice to reflect this in the commit log. Also, PostgreSQL database support standard knob is PGSQL, not POSTGRES (per our KNOBS file). If you decide to fix this, I would also mention that "Posgres" is obvious typo (should be spelled "PostgreSQL", not "Posgres" or "Postgres"), and "Use ?? Backend" sounds ambiguous (use as "use exclusively" or "enable support for"?); "Backend" should also be spelled lowercase. Would you like me to take care of these issues, perhaps? ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100310182947.GA75413>