Date: Tue, 22 May 2012 14:06:10 +0800 From: Kevin Lo <kevlo@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: Garrett Cooper <yanegomi@gmail.com>, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Baptiste Daroussin <baptiste.daroussin@gmail.com> Subject: Re: svn commit: r235771 - head/bin/expr Message-ID: <1337666770.2289.7.camel@nsl> In-Reply-To: <20120522054113.GL63744@ithaqua.etoilebsd.net> References: <201205220301.q4M31tJn084097@svn.freebsd.org> <CAGH67wR9OCq93bWCfJPn6WXNFfVUthBrUhtxpHDRVQXWavx9yg@mail.gmail.com> <20120522054113.GL63744@ithaqua.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Baptiste Daroussin wrote: > On Mon, May 21, 2012 at 09:20:59PM -0700, Garrett Cooper wrote: > > On Mon, May 21, 2012 at 8:01 PM, Kevin Lo <kevlo@freebsd.org> wrote: > > > Author: kevlo > > > Date: Tue May 22 03:01:54 2012 > > > New Revision: 235771 > > > URL: http://svn.freebsd.org/changeset/base/235771 > > > > > > Log: > > > Remove redundant declaration of yyparse > > > > > > Reported by: tinderbox > > > > > > Modified: > > > head/bin/expr/expr.y > > > > > > Modified: head/bin/expr/expr.y > > > ============================================================================== > > > --- head/bin/expr/expr.y Tue May 22 02:37:04 2012 (r235770) > > > +++ head/bin/expr/expr.y Tue May 22 03:01:54 2012 (r235771) > > > @@ -74,7 +74,6 @@ int to_integer(struct val *); > > > void to_string(struct val *); > > > int yyerror(const char *); > > > int yylex(void); > > > -int yyparse(void); > > > > > > %} > > > > There are a lot more than just this unfortunately (I'm working on > > a complete patchset). > > This breakage really makes me think that yacc isn't being built at > > the right time or pathed properly in the build system. > > Thanks, > > -Garrett > > _______________________________________________ > > svn-src-all@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/svn-src-all > > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" > > The complete patch set is there: > http://people.freebsd.org/~bapt/fix-after-yacc.diff > (clang seems to not detect those redudant warning, while gcc complains) > > I'm waiting for review before committing) > > Thanks for this fix I'll remove it from my patchset Looks good to me. Thanks for cooking up the patchset. > regards, > Bapt Kevin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1337666770.2289.7.camel>