Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 8 Apr 2005 15:34:14 -0400
From:      "Will Saxon" <WillS@housing.ufl.edu>
To:        <usb@freebsd.org>
Subject:   Please commit fix outlined in PR/63837
Message-ID:  <0E972CEE334BFE4291CD07E056C76ED8062D2491@bragi.housing.ufl.edu>

next in thread | raw e-mail | index | archive | help
Is it possible to get the 1 line fix posted in PR/63837 added=20
before 5.4? This has been a problem since before 5.3, the fix is=20
trivial and it works fine.

It is kind of annoying to have to edit hid.c every time I cvsup.

This has been asked about before by myself and others... Is there
a stylistic problem or a planned cleanup that has held this back?

--- /usr/src/sys/dev/usb/hid.c.orig  Fri Apr  8 15:26:46 2005
+++ /usr/src/sys/dev/usb/hid.c       Fri Apr  8 14:55:01 2005
@@ -375,7 +375,7 @@

	id =3D 0;
	for (d =3D hid_start_parse(buf, len, 1<<k); hid_get_item(d, &h); )
-		if (h.report_ID !=3D 0)
+ 		if (h.report_ID !=3D 0 && !id)
			id =3D h.report_ID;
	hid_end_parse(d);
	size =3D h.loc.pos;

-Will



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0E972CEE334BFE4291CD07E056C76ED8062D2491>