Date: Fri, 13 Apr 2007 19:08:32 -0400 From: Joe Marcus Clarke <marcus@marcuscom.com> To: Gerald Pfeifer <gerald@pfeifer.com> Cc: Pav Lucistnik <pav@freebsd.org>, Rong-en Fan <grafan@gmail.com>, freebsd-ports@freebsd.org, Andy Fawcett <andy@athame.co.uk> Subject: Re: Generating INDEX Message-ID: <1176505712.21770.39.camel@shumai.marcuscom.com> In-Reply-To: <Pine.LNX.4.64.0704140007050.32062@acrux.dbai.tuwien.ac.at> References: <461E1CC8.7090606@adestra.com> <200704121918.21307.andy@athame.co.uk> <6eb82e0704121003n30a209c5y25d8f64ba6b43eeb@mail.gmail.com> <Pine.LNX.4.64.0704130820460.32062@acrux.dbai.tuwien.ac.at> <6eb82e0704130439w40d38a80h69d059b26c8189d3@mail.gmail.com> <1176486909.11148.0.camel@ikaros.oook.cz> <Pine.LNX.4.64.0704140007050.32062@acrux.dbai.tuwien.ac.at>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-Pu6VpEV78QsddlBtOd02 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sat, 2007-04-14 at 00:32 +0200, Gerald Pfeifer wrote: > On Fri, 13 Apr 2007, Rong-en Fan wrote: > > No, the patch won't work. According to > > http://www.freebsd.org/gnome/docs/porting.html, > > the right way is always define WANT_GNOME which won't pull > > any gnome dependencies unless USE_GNOME is used. > >=20 > > I think after USE_PERL5_BUILD line, add > >=20 > > WANT_GNOME=3Dyes > >=20 > > and use +=3D for USE_GNOME after bsd.port.pre.mk >=20 > Thanks. This matches my reading of=20 > http://www.freebsd.org/gnome/docs/porting.html as well, so I committed > the patch at the end of this message to hopefully address the breakage. >=20 > On Fri, 13 Apr 2007, Pav Lucistnik wrote: > >> I think after USE_PERL5_BUILD line, add > >>=20 > >> WANT_GNOME=3Dyes > >>=20 > >> and use +=3D for USE_GNOME after bsd.port.pre.mk > > The usual workaround is > >=20 > > USE_GNOME=3D # empty > >=20 > > .include <bsd.port.pre.mk> > >=20 > > USE_GNOME+=3D foo bar baz >=20 > What Rong-en proposed matches my reading of our GNOME porting=20 > documentation, and according to my reading of bsd.port.mk your=20 > proposal is just another way of achieving the same result. Is > this correct? >=20 > What worries me more is that the same documentation also has: >=20 > Note: You cannot add extra default USE_GNOME components after the=20 > .include <bsd.port.pre.mk>. That is, the following is wrong : >=20 > .include <bsd.port.pre.mk> >=20 > .if ${HAVE_GNOME:Mgnomelibs}!=3D"" > USE_GNOME+=3D libgnome > .else > USE_GNOME+=3D gtk12 # WRONG! > .endif > =20 > and lang/gcc41 has the following right now after .include=20 > <bsd.port.pre.mk>: >=20 > USE_GNOME=3D gtk20 libartlgpl2 >=20 > Should we move the USE_GNOME=3Dgtk20 part into lang/gcc41-withgcjawt > and only keep USE_GNOME+=3Dlibartlgpl2 at this point in lang/gcc41 or > is the current use okay in this specific setting? The statement above affects the setting of PLIST_SUB. If you are not relying on the values of GNOME:, NOGNOME:, GNOMEDESKTOP:, and NOGNOMEDESKTOP: in PLIST_SUB, then you don't need to worry. In any case, using USE_GNOME once after bsd.port.pre.mk is always fine. Joe >=20 > Gerald >=20 > PS: For now I committed the patch below which ought to be correct in > any case. I won't be able to be online too much over the weekend, so > if any of you please be more than welcome to apply any followup patch > as needed if you are confident it is the right thing to do. >=20 > Index: Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /home/pcvs/ports/lang/gcc41/Makefile,v > retrieving revision 1.318 > diff -u -3 -p -r1.318 Makefile > --- Makefile 10 Apr 2007 05:24:27 -0000 1.318 > +++ Makefile 13 Apr 2007 22:06:51 -0000 > @@ -34,6 +34,7 @@ USE_BZIP2=3D yes > USE_GMAKE=3D yes > USE_ICONV=3D yes > USE_PERL5_BUILD=3Dyes > +WANT_GNOME=3D yes > =20 > PATCH_WRKSRC=3D ${SRCDIR} > CONFIGURE_SCRIPT=3D ../${SRCDIR:C/${WRKDIR}//}/configure > _______________________________________________ > freebsd-ports@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-ports > To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org" >=20 --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-Pu6VpEV78QsddlBtOd02 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQBGIA1vb2iPiv4Uz4cRAuN2AJ4jKlu2XwJaD0wD/w8+4RPwCaDMggCgiBlz CsZy63zpVqOSbZhZkPrCOh4= =kQUS -----END PGP SIGNATURE----- --=-Pu6VpEV78QsddlBtOd02--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1176505712.21770.39.camel>