Date: Tue, 11 Nov 2014 11:34:52 -0500 From: John Baldwin <jhb@freebsd.org> To: Andrey Chernov <ache@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, Garrett Cooper <ngie@freebsd.org>, Garrett Cooper <yaneurabeya@gmail.com> Subject: Re: svn commit: r274365 - head/contrib/tzcode/stdtime Message-ID: <201411111134.52984.jhb@freebsd.org> In-Reply-To: <54623400.1080407@freebsd.org> References: <201411110407.sAB47gBT003976@svn.freebsd.org> <920BE50C-2DBA-4DCE-BFAB-ACFC11C5A09E@gmail.com> <54623400.1080407@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, November 11, 2014 11:06:24 am Andrey Chernov wrote: > On 11.11.2014 18:34, Garrett Cooper wrote: > >> This code is wrong in any case, setting EOVERFLOW even in unneeded > >> no-error cases like breaking from the loop. See how NetBSD does it > >> correctly instead. > > > > Hi! > > I saw your reply earlier but hadn't gotten an opportunity to revise the patch like you suggested. I'll look at the NetBSD code and see if I can adapt it to our copy of tzcode. > > Thank you! > > > > Currently as we need only EOVERFLOW parts from it, I don't think it will > be hard task to merge only them. Do you know if it is fixed upstream? I want to import newer tzcode from upstream to get implementations of the extensions to allow use of arbitrary time zones (mktime_z, etc.) -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201411111134.52984.jhb>