Date: Wed, 4 Aug 2010 07:49:40 +0000 (UTC) From: Gavin Atkinson <gavin@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r210839 - head/sys/dev/sound/pci/hda Message-ID: <201008040749.o747ne3B004638@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: gavin Date: Wed Aug 4 07:49:40 2010 New Revision: 210839 URL: http://svn.freebsd.org/changeset/base/210839 Log: Do not free sc if attach failed, as it was allocated by the bus infrastructure, not us. This appears to be a leftover from an older version of the driver. Submitted by: avg Tested by: Anton Shterenlikht <mexas bristol.ac.uk> MFC after: 1 week X-MFC-Note: To stable/8 and stable/7 only Modified: head/sys/dev/sound/pci/hda/hdac.c Modified: head/sys/dev/sound/pci/hda/hdac.c ============================================================================== --- head/sys/dev/sound/pci/hda/hdac.c Wed Aug 4 07:47:19 2010 (r210838) +++ head/sys/dev/sound/pci/hda/hdac.c Wed Aug 4 07:49:40 2010 (r210839) @@ -4314,7 +4314,6 @@ hdac_attach_fail: hdac_dma_free(sc, &sc->corb_dma); hdac_mem_free(sc); snd_mtxfree(sc->lock); - free(sc, M_DEVBUF); return (ENXIO); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201008040749.o747ne3B004638>