Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 4 Dec 1998 11:37:16 +0300
From:      "Andrey A. Chernov" <ache@nagual.pp.ru>
To:        Bruce Evans <bde@zeta.org.au>, dillon@apollo.backplane.com
Cc:        cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG
Subject:   Re: cvs commit: src/sys/netinet icmp_var.h ip_icmp.c tcp_input.c udp_usrreq.c
Message-ID:  <19981204113716.B19232@nagual.pp.ru>
In-Reply-To: <199812040830.TAA13675@godzilla.zeta.org.au>; from bde@zeta.org.au on Fri, Dec 04, 1998 at 07:30:10PM %2B1100
References:  <199812040830.TAA13675@godzilla.zeta.org.au>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Dec 04, 1998 at 07:30:10PM +1100, Bruce Evans wrote:
> Rules for avoiding messes like this:
> - Options headers shall never be included in headers.

I agree with this. If you need optional header and some stuff in the
header depend on it, include it before the header, not into.

> - Always use OID_AUTO for new sysctls.  (XXX_MAXID and XXX_NAMES
>   definitions are never used, so even if you don't use OID_AUTO, the
>   only reason to add them is for BSD4.4 compatibility in case we decide
>   to throw out phk's reimplementation of sysctl).

Hmm. Can't say anything.

-- 
Andrey A. Chernov
http://www.nagual.pp.ru/~ache/
MTH/SH/HE S-- W-- N+ PEC>+ D A a++ C G>+ QH+(++) 666+>++ Y

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19981204113716.B19232>