Date: Thu, 12 Jul 2001 07:43:18 -0700 From: Mark Peek <mark@whistle.com> To: Dima Dorfman <dima@unixfreak.org>, Matt Dillon <dillon@earth.backplane.com> Cc: stable@FreeBSD.ORG Subject: Re: cron exited on signal 11 Message-ID: <p05100301b773646194ff@[207.76.207.129]> In-Reply-To: <20010712082517.E7B7D3E2F@bazooka.unixfreak.org> References: <20010712082517.E7B7D3E2F@bazooka.unixfreak.org>
next in thread | previous in thread | raw e-mail | index | archive | help
At 1:25 AM -0700 7/12/01, Dima Dorfman wrote: >Notice the call to env_free(). That routine does proper piecemeal >cleanup in all cases and for all members of the structure except >`class' (which wasn't there when the original author wrote the >program). It may not have been the right choice, but it's already >been made, and I think remaining consistent with the rest of the file >(or routine) is desirable. Changing free_entry() to support partially >initialized structures may mask bugs. This is the only routine that >initializes the structure and it does it completely; if a field isn't >initialized, that's a bug. > >I guess what I'm saying is that although I wouldn't write it like >that, since it's already written it'd be nice to remain consistent. OK, so that makes 3 of us that would prefer having it rewritten to allow free_entry() to clean up partially initialized structures. Dima, perhaps we should consult with the previous author to review your patches and weigh in to this discussion. Mark To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?p05100301b773646194ff>