Date: Tue, 20 Oct 1998 04:41:36 -0700 (PDT) From: shirai@nintnedo.co.jp To: freebsd-gnats-submit@FreeBSD.ORG Subject: i386/8382: [PATCH] /stand/sysinstall don't unmount CD-ROM Message-ID: <199810201141.EAA06954@hub.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 8382 >Category: i386 >Synopsis: [PATCH] /stand/sysinstall don't unmount CD-ROM >Confidential: no >Severity: critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Oct 20 04:50:01 PDT 1998 >Last-Modified: >Originator: Takashi SHIRAI >Organization: >Release: 2.2.6-RELEASE >Environment: FreeBSD chandra2 2.2.6-RELEASE FreeBSD 2.2.6-RELEASE #0: Fri Sep 4 11:48:37 JST 1998 shirai@chandra2:/usr/src/sys/compile/chandra2 i386 >Description: In case that no item is selected in packages installation with /stand/sysinstall, sysinstall don't unmount CD-ROM device at the end. (The other devices have no problem.) Following is the patch. diff -ur ../sysinstall/cdrom.c ./cdrom.c --- ../sysinstall/cdrom.c Wed Jan 29 10:11:22 1997 +++ ./cdrom.c Thu Oct 1 12:26:45 1998 @@ -83,7 +83,6 @@ msgConfirm("Error mounting %s on %s: %s (%u)", dev->devname, mountpo int, strerror(errno), errno); return FALSE; } - cdromMounted = TRUE; } if (!file_readable(string_concat(mountpoint, "/cdrom.inf"))) { @@ -122,6 +121,7 @@ } } msgDebug("Mounted FreeBSD CDROM from device %s\n", dev->devname); + cdromMounted = TRUE; return TRUE; } But, this patch is not enough. Even if the directory /dist is already mounted by CD-ROM from the first, sysinstall will unmount /dist to exit. I think that it's necessary to prepare the flag telling if mounted already or not. This problem is not concernd only the CD-ROM device, but all devices. >How-To-Repeat: With /stand/sysinstall, select Configure -> Packages -> CDROM, and exit at once. You will find /dist in the output of `df`. >Fix: The patch is effective, and you must fix not to unmount already mounted /dist. >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199810201141.EAA06954>