Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 17 Sep 2003 09:07:24 +0200
From:      "Poul-Henning Kamp" <phk@phk.freebsd.dk>
To:        Bruce Evans <bde@zeta.org.au>
Cc:        Kris Kennaway <kris@obsecurity.org>
Subject:   Re: panic: Negative bio_offset (-15050100712783872) on bio 0xc7725d50 
Message-ID:  <24374.1063782444@critter.freebsd.dk>
In-Reply-To: Your message of "Tue, 16 Sep 2003 10:42:38 %2B1000." <20030916102534.J2924@gamplex.bde.org> 

next in thread | previous in thread | raw e-mail | index | archive | help
In message <20030916102534.J2924@gamplex.bde.org>, Bruce Evans writes:

>This is either disk corruption or an ffs bug.  ffs passes the garbage
>block number 0xffffe5441ae9720 to bread.  GEOM then handles this austerely
>by panicing.  Garbage block numbers, including negative ones, can possibly
>be created by applications seeking to preposterous offsets, so they should
>not be handled with panics.

They most certainly should!  If the range checking in any filesystem
is not able to catch these cases I insist that GEOM do so with a panic.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?24374.1063782444>