Date: Thu, 25 Jun 2009 14:45:12 -0400 From: Ken Smith <kensmith@cse.Buffalo.EDU> To: freebsd-arch@freebsd.org Subject: Time to drop the warning for uid's bigger than USHRT_MAX? Message-ID: <1245955512.20785.14.camel@bauer.cse.buffalo.edu>
next in thread | raw e-mail | index | archive | help
--=-X21KY1w0czHTT/BbE3za
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
John's work on the SYSV IPC stuff removes the last place I'm aware of
that had an issue with uid's bigger than what will fit inside an
unsigned short. So, a couple questions:
1) Does anyone know of any remaining places I'm not aware of?
And, if the answer to that winds up being no...
2) lib/libc/gen/pw_scan.c has some support for providing warnings
about there potentially being issues with using uid's larger than
a certain value. Should the code for that remain in place "for the
next time we have this issue" despite it not really being needed
now or should it all just get ripped out?
Given John's work just arrived and it was a pre-requisite to doing
anything about this RE would probably allow for any changes related to
this happening after code freeze starts but it should happen soon if
it's going to happen at all. ;-) Personally I'm leaning towards
adjusting things so the warnings get triggered at UID_MAX for now and
providing a few comments that say "We know this looks unnecessary right
now but there was a time when ...".
Thanks...
--=20
Ken Smith
- From there to here, from here to | kensmith@cse.buffalo.edu
there, funny things are everywhere. |
- Theodore Geisel |
--=-X21KY1w0czHTT/BbE3za
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)
iEYEABECAAYFAkpDxa4ACgkQ/G14VSmup/a9UACfYmFWIs1PzVgZw4XMZLzO0SPj
/BMAoJV9mVyVnUfQ/LCbyt8FVDsnuad8
=BFVt
-----END PGP SIGNATURE-----
--=-X21KY1w0czHTT/BbE3za--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1245955512.20785.14.camel>