Date: Sun, 30 Apr 2000 02:40:20 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: "Andrey A. Chernov" <ache@FreeBSD.ORG> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/bin/stty extern.h gfmt.c key.c print.c stty.c stty.h Message-ID: <Pine.BSF.4.21.0004300229010.315-100000@alphplex.bde.org> In-Reply-To: <20000428044403.B17180@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 28 Apr 2000, Andrey A. Chernov wrote: > On Fri, Apr 28, 2000 at 03:36:51PM +1000, Bruce Evans wrote: > > > ache 2000/04/27 14:31:24 PDT > > > > > > Modified files: > > > bin/stty extern.h gfmt.c key.c print.c stty.c > > > stty.h > > > Log: > > > Add ability to manipulate with drain wait time > > > > Please back this out. > > > > Controlling the drainwait time is a standard feature of comcontrol(8). > > Someone named ache implemented it back in 1995 :-). I think the division > > of tty control into standard features in stty and nonstandard features > > in comcontrol is correct. > > I disagree. There is no harm to implement it here too, better to have all > tty-related stuff in one place to see whole picture on what happens with > tty. I.e. whole state of all things can be changed. It is not > human-oriented to have two separate programs forcing user to join their > states in mind. This change also breaks stty on inital-state and lock-state devices. E.g., "stty </dev/cuaia0" now gives the misphrased error message: --- stty: TIOCGDRAINWAIT: Inappropriate ioctl for device : Inappropriate ioctl for device --- The duplicated message is caused by a bogus ": %s\n" in the format for warn(). This bug was apparently copied from an old bug in the warning for TIOCGWINSZ. Please back this out :-). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0004300229010.315-100000>