Date: Sat, 11 Sep 2010 08:47:37 -0400 From: Wesley Shields <wxs@FreeBSD.org> To: Koop Mast <kwm@FreeBSD.org> Cc: gnome@freebsd.org, pgollucci@freebsd.org Subject: Re: ruby-gnome update for review Message-ID: <20100911124737.GA4175@atarininja.org> In-Reply-To: <1284204971.21059.2109.camel@headache.rainbow-runner.nl> References: <4C86E527.4030308@mouf.net> <1284204971.21059.2109.camel@headache.rainbow-runner.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Sep 11, 2010 at 01:36:11PM +0200, Koop Mast wrote: > On Tue, 2010-09-07 at 21:21 -0400, Steve Wills wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA1 > > > > Hi, > > > > Please see this patch which attempts to update the ruby-gnome ports: > > > > http://people.freebsd.org/~swills/ruby_gnome_update_patch.txt > > Looking good, don't forget to reset PORTREVISION's :) Agreed. Since you are bumping PORTVERSION on these you should reset PORTREVISION. No need to resubmit a patch for approval for that, consider it approved provided you do that. > > > > I've run test builds on 8.1 and 7.4. The logs can be found here: > > > > http://people.freebsd.org/~swills/FreeBSD/logs/ > > > > I've done run time testing using "erubychess" (not in ports): > > > > http://rubyforge.org/projects/erubychess/ > > > > Proposed commit message: > > - --------------------- > > - - Update ruby-gnome ports to 0.19.4 > > > > Approved by: gnome@, X (mentor) > > - --------------------- > > I think this is beter, since gnome@ doesn't maintain these ports. > > - --------------------- > Approved by: X (mentor) > Reviewed by: kwm (gnome@) > - --------------------- Agreed here too. Thanks Koop for the review! -- WXS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100911124737.GA4175>