Date: Sun, 10 May 2015 19:14:06 +0200 From: Hans Petter Selasky <hps@selasky.org> To: Oliver Pinter <oliver.pinter@hardenedbsd.org> Cc: Wolfgang Zenker <wolfgang@lyxys.ka.sub.org>, freebsd-current@freebsd.org Subject: Re: Race VT+X11 on -current Message-ID: <554F91DE.8010209@selasky.org> In-Reply-To: <CAPQ4ffuBNahdwrj6kGustSBk9V3qr1CP%2B-5__Cp-F2wqbB6=Rg@mail.gmail.com> References: <CAN6yY1vno%2B-nV9zBYp11A=F-vAURbhraEFyQR_ue4W7h8pQUMw@mail.gmail.com> <AA8B24D1-DF5A-42CD-8755-15EF3C46E760@gmail.com> <554BC475.50203@selasky.org> <554BD2A8.70702@selasky.org> <554C3CCB.3030809@selasky.org> <4937E44E-C0EF-4052-961C-F46D5EC5BE00@gmail.com> <554C8AEB.2080502@selasky.org> <554CC841.60908@freebsd.org> <20150509210525.GA80848@lyxys.ka.sub.org> <554F5379.2070100@selasky.org> <20150510165330.GA86856@lyxys.ka.sub.org> <554F8BA6.9000702@selasky.org> <CAPQ4ffuBNahdwrj6kGustSBk9V3qr1CP%2B-5__Cp-F2wqbB6=Rg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 05/10/15 19:00, Oliver Pinter wrote: > Hi Hans! > > > Hi, >> >> Sounds good. I'll MFC the patch sometime next week. Seems like more >> people need it for daily FreeBSD use :-) > > I have this fix or enhancements in our HardenedBSD codebase: > https://github.com/HardenedBSD/hardenedBSD/commit/18058137da01598403b6ffa40c37b0a907441530 > Please review them, and if you feel this required in FreeBSD too, and > cherry-pick them. > Hi Oliver, Your patch is correct from what I can see. Signed modulus can be creepy sometimes! Better if VT_MAXWINDOWS was power of two and we used a bitwise AND. https://svnweb.freebsd.org/changeset/base/282730 --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?554F91DE.8010209>