Date: Sat, 2 Feb 2013 16:50:13 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Andriy Gapon <avg@FreeBSD.org> Cc: freebsd-hackers@FreeBSD.org, freebsd-current@FreeBSD.org Subject: Re: scheduler->swapper, SI_SUB_RUN_SCHEDULER->SI_SUB_LAST Message-ID: <20130202145013.GV2522@kib.kiev.ua> In-Reply-To: <510CFD90.9000304@FreeBSD.org> References: <510CFD90.9000304@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--0ujaWV404FI0kHa9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Feb 02, 2013 at 01:50:40PM +0200, Andriy Gapon wrote: >=20 > I would like to propose the following mostly cosmetic change: > http://people.freebsd.org/~avg/scheduler-swapper.diff >=20 > This is something that bit me early in my FreeBSD days, so I am kind of o= bsessed > with it. > The current naming is confusing/misleading indeed. > And magic properties of SI_SUB_RUN_SCHEDULER:SI_ORDER_LAST is a "hidden g= em". You may remove the Giant unlock from the scheduler()/swapper() as well then, doing it before the swapper() call in the mi_startup(). Note that the wait chain for the idle swapper is still called "sched". --0ujaWV404FI0kHa9 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQIcBAEBAgAGBQJRDSelAAoJEJDCuSvBvK1B6usP/i4nVfbHVB++Sk8BUy5+zrIM B+dAEnb64hEnELVjcQfAYO7+UDkgMMo63eVmgq8kYtiVBJ7bF6+QxbjNObubXM7B 0MbLpcHgnwtwuqMF4swVofJzR7pqbqo7lq3E5R9Bd57kZJfhzNS7CPhycX4HQiV0 WZZB1SLz+eoc+jfyFgOSfR+Eq9hrrPS2lH2k76FwScU1x0IpiTnkaYkfcs0QYqgW z0AqRmQjAEl9V8HyM4b2qTa+6k0K+HiXaQMNzpn+GZhlpjmmVe7pQy2fy/5NBAzU rK0dxu2J0FH1PEJgLwJIIlMYl0MI3KjeX1O4QmCkQLros0o6+ZwQ7t0irRsydGsX dJI7T57i3+BZvo61Uq3snFRbkiIBKhUtnwTBWF9z+qSJW10Ma+UcASltN0/6YFhP trdcVqbN4jsOLpYTAGBLgxzf4LjqzVHeNPX3wmL42LfFXmwPm7mYbbKsucbfxFCQ WJvbJCvo/PMzwHCK+aC0UueZ1yI8nx95oGp+HWQGc6AgD9PmmzWMZng9gAdUK5kO +v1S4t7aQymjASwUtNpHZnjC+keQy/Zk/L7GT0mveD0hm7+jtlAKqzBkqTS/7dfJ yba9uoxT3gZpYkEA7GmSerERJfDvXAF1azYUdzhk9Kcu8lX8OTvsov0xjUrXIL5J 9oH+HRNGtfKWsdN2QH1y =qdWH -----END PGP SIGNATURE----- --0ujaWV404FI0kHa9--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130202145013.GV2522>