Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 25 Aug 2004 14:21:49 -0700
From:      Brooks Davis <brooks@one-eyed-alien.net>
To:        Tilman Linneweh <arved@freebsd.org>
Cc:        rwatson@freebsd.org
Subject:   Re: kern/33201: net/net_osdep.c:if_name is broken
Message-ID:  <20040825212149.GA9405@odin.ac.hmc.edu>
In-Reply-To: <200408252059.i7PKx1fV014645@freefall.freebsd.org>
References:  <200408252059.i7PKx1fV014645@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--5mCyUwZo2JvN/JJP
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Aug 25, 2004 at 08:59:01PM +0000, Tilman Linneweh wrote:
> Synopsis: net/net_osdep.c:if_name is broken
>=20
> State-Changed-From-To: open->feedback
> State-Changed-By: arved
> State-Changed-When: Wed Aug 25 20:56:22 GMT 2004
> State-Changed-Why:=20
> It looks like this was resolved with the if_xname commit.
> Can this PR be closed?

Unless we care about fixing it in stable, we can close this.  if_name()
is correct other then a couple style bugs.

We might want to just nuke net_osdep.c and replace if_name() with:

#define	if_name(ifp)	((ifp)->if_xname)

This was over a year ago in NetBSD.

-- Brooks

--=20
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4

--5mCyUwZo2JvN/JJP
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQFBLQLsXY6L6fI4GtQRAjZaAKDGLo1+78wuHYHL1Gu3xvSVDMqIeQCfUq9A
RejPauD+j1Dr5su9I1M0yq0=
=tlSF
-----END PGP SIGNATURE-----

--5mCyUwZo2JvN/JJP--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040825212149.GA9405>