Date: Wed, 25 Apr 2007 01:17:20 +0800 From: Ariff Abdullah <ariff@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: freebsd-i386@freebsd.org, freebsd-amd64@freebsd.org Subject: Re: AMD64 K8 Family C1E dead apic timer fixup Message-ID: <20070425011720.5725e654.ariff@FreeBSD.org> In-Reply-To: <200704241147.57194.jhb@freebsd.org> References: <20070420195444.20bc4d3a.ariff@FreeBSD.org> <200704231446.54021.jhb@freebsd.org> <20070424093959.17d74e0b.ariff@FreeBSD.org> <200704241147.57194.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Signature=_Wed__25_Apr_2007_01_17_20_+0800_CXpG/B34XnCyhuF4 Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, 24 Apr 2007 11:47:56 -0400 John Baldwin <jhb@freebsd.org> wrote: > On Monday 23 April 2007 09:39:59 pm Ariff Abdullah wrote: > > On Mon, 23 Apr 2007 14:46:53 -0400 > > John Baldwin <jhb@freebsd.org> wrote: > > > On Friday 20 April 2007 07:54:44 am Ariff Abdullah wrote: > > > > Will anybody object if I (or somebody else) commit this patch? > > > >=20 > > > > http://people.freebsd.org/~ariff/test/k8_c1e.diff > > > >=20 > > > > This should "fix" dead apic timer issues on latest AMD64 > > > > (Turion64 X2 mostly, or later revision) where C1 Enhanced > > > > (C1E) mode enabled. > > > >=20 > > > > Without this, the only way to make the timer work is to > > > > disable APIC or even worst, to avoid executing HLT instruction > > > > (machdep.cpu_idle_hlt=3D0), smp or non-smp. It affect both i386 > > > > and amd64. > > > >=20 > > > > See PR: i386/104678 for details. > > >=20 > > > Does this fix all of the Turion lapic timer hangs? > >=20 > > Yes, and hopefully to the later revisions (if any) as well. >=20 > Ok, cool. >=20 > > > Some small tweaks to the comment would be: > > >=20 > > > - s/present/presence/ > > > - s/render/renders/ > > > - s/apic timer/local APIC timer/ > > > - s/dead, and/dead, so/ > > > - s/reading Interrupt/reading the Interrupt/ > > > - s/unset/clearing/ > > >=20 > >=20 > > Thanks. > >=20 > > > Also, is it ok to always mask off the upper 31 bits of the MSR > > > instead of preserving their current state? > > >=20 > > It should work either way, since the upper bits are read only. >=20 > Why bother masking it off then? >=20 Except of my personal tendency to kill it, I don't think we need to mask it off. See latest patch (same link). -- Ariff Abdullah FreeBSD ... Recording in stereo is obviously too advanced and confusing for us idiot ***** users :P ........ --Signature=_Wed__25_Apr_2007_01_17_20_+0800_CXpG/B34XnCyhuF4 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQFGLjuglr+deMUwTNoRAjCeAKDRVuDe1FHJ35u/FN/Ol6W/PAJvRACfQIwk 9bo9Gq3USSafTkZ7CcF3sx8= =Bs01 -----END PGP SIGNATURE----- --Signature=_Wed__25_Apr_2007_01_17_20_+0800_CXpG/B34XnCyhuF4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070425011720.5725e654.ariff>