Date: Wed, 18 Dec 2013 11:43:28 -0800 From: Adrian Chadd <adrian@freebsd.org> To: =?ISO-8859-1?Q?Jean=2DS=E9bastien_P=E9dron?= <dumbbell@freebsd.org> Cc: dt71@gmx.com, "freebsd-current@freebsd.org" <freebsd-current@freebsd.org>, Robert Noland <rnoland@freebsd.org> Subject: Re: new Xorg (KMS, etc.) for Radeon 9600 Message-ID: <CAJ-Vmo=_vHi_NG_3aOW00_aGwDV==wP-h6BNBx6DA0k-cA8zvw@mail.gmail.com> In-Reply-To: <52B17777.6060703@FreeBSD.org> References: <527F95BE.7080908@gmx.com> <Pine.GSO.4.64.1311101135590.9459@sea.ntplx.net> <527FC05D.8080703@gmx.com> <5283E123.5000305@FreeBSD.org> <20131114113846.4dcb2037@kalimero.tijl.coosemans.org> <52858067.2060200@gmx.com> <52AEAD7A.1040205@gmx.com> <52B0C004.9010702@FreeBSD.org> <52B14384.5060102@gmx.com> <52B17777.6060703@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[snip] So the standard trop of UNLOCK/WORK/RELOCK is pretty dangerous. There's no state re-validation going on when you re-acquire that lock. So, although it meets the lock requirements, it may not be 'correct'. It's scattered throughout the code base (wifi drivers aren't an exception here either, sigh.) Just something to keep in mind when you validate the 'correctness' of this kind of lock hack. -adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmo=_vHi_NG_3aOW00_aGwDV==wP-h6BNBx6DA0k-cA8zvw>