Date: Tue, 22 Jun 2004 08:33:41 +0200 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Colin Percival <colin.percival@wadham.ox.ac.uk> Cc: current@freebsd.org Subject: Re: vinum crashing with latest current Message-ID: <33557.1087886021@critter.freebsd.dk> In-Reply-To: Your message of "Tue, 22 Jun 2004 05:34:02 BST." <6.1.0.6.1.20040622051016.03cae4e8@popserver.sfu.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <6.1.0.6.1.20040622051016.03cae4e8@popserver.sfu.ca>, Colin Percival
writes:
>Now, I'm not sure which of these is correct, but ONE of the following
>two patches should be applied:
>--- src/sys/dev/vinum/vinumio.c 17 Jun 2004 17:16:47 -0000 1.99
>+++ src/sys/dev/vinum/vinumio.c 22 Jun 2004 04:29:08 -0000
>@@ -68,7 +68,7 @@ open_drive(struct drive *drive, struct t
> drive->lasterror = ENOTBLK;
> else {
> DROP_GIANT();
>- drive->lasterror = (dsw->d_open) (drive->dev, FWRITE | FREAD, 0, NULL);
>+ drive->lasterror = (dsw->d_open) (drive->dev, FWRITE | FREAD, 0, td);
> PICKUP_GIANT();
> }
>
It'll have to be this one.
--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?33557.1087886021>