Date: Sun, 13 Oct 2013 16:18:22 +0100 From: Mark R V Murray <mark@grondar.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Mark Murray <markm@FreeBSD.org> Subject: Re: svn commit: r256377 - in head: etc/defaults etc/rc.d share/examples/kld/random_adaptor share/man/man4 sys/boot/forth sys/conf sys/dev/glxsb sys/dev/hifn sys/dev/random sys/dev/rndtest sys/dev/safe ... Message-ID: <812C1C64-75B0-4FE9-8FCD-B25A484448C6@grondar.org> In-Reply-To: <20131013151359.GR41229@kib.kiev.ua> References: <201310121257.r9CCvvjO006546@svn.freebsd.org> <20131013074825.GO41229@kib.kiev.ua> <3B77143C-7D82-4E62-9974-BC2C6846893F@grondar.org> <20131013151359.GR41229@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_12CC3E7C-9487-46CC-8C67-9C690235F253 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 13 Oct 2013, at 16:13, Konstantin Belousov <kostikbel@gmail.com> wrote: > Surely this works, thank you. The rwfile.c content probably should be > taken under the #ifdef RANDOM_RWFILE. OK - thanks for the feedback! > But I do not see much use for the randomdev_read_file() and > randomdev_write_file() functions. It would be better to directly code > the VFS calls in the random_harvestq_cache(). For one thing, it would > eliminate unneccessary close and open of the entropy file. There is some uncertainty about the future of that code, so I want to keep it that way for now. Writing files from the kernel is making so@ very uncomfortable, and there is too much scope for error there. We'll settle it down properly in 11.*. M -- Mark R V Murray --Apple-Mail=_12CC3E7C-9487-46CC-8C67-9C690235F253 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.20 (Darwin) Comment: GPGTools - http://gpgtools.org iQCVAwUBUlq5vt58vKOKE6LNAQomJQQAo8/Uc/cgHY5UY8V9KyZhlFrO5p6VMsbI 37TszhBH72SzjQHQC0tkbS1ekCXWwkqxjMTrOqgdayrF3PGJIan8kKKZ+h96KV0k jVeBqVpX8R+BhaG7Af1SjhXQDIBRdjl0+LTG07VCkcPEJKxXCl5UXtzKW76WFWWf +B0tUYaRBHc= =Gn/+ -----END PGP SIGNATURE----- --Apple-Mail=_12CC3E7C-9487-46CC-8C67-9C690235F253--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?812C1C64-75B0-4FE9-8FCD-B25A484448C6>