Date: Mon, 02 Sep 2002 14:34:52 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: peter@wemm.org Cc: bde@zeta.org.au, obrien@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile src/usr.bin/make Makefile Message-ID: <20020902.143452.50744905.imp@bsdimp.com> In-Reply-To: <20020902185112.1016F2A896@canning.wemm.org> References: <20020903011057.W3883-100000@gamplex.bde.org> <20020902185112.1016F2A896@canning.wemm.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20020902185112.1016F2A896@canning.wemm.org> Peter Wemm <peter@wemm.org> writes: : Bruce Evans wrote: : > On Mon, 2 Sep 2002, Peter Wemm wrote: : > : > > "David O'Brien" wrote: : > > > On Sat, Aug 31, 2002 at 12:18:40AM -0700, Peter Wemm wrote: : > > > [about -DBOOTSTRAPPING and newer warts] : > : > > > I thought we were going to impliment these warts with some form of : > > > __FreeBSD_version test -- so they don't impact source bases that don't : > > > need them, and more importantly so it is documented the time range they : > > > cover so we know when to remove them. : > > : > > Go for your life. Personally, I think that this sort of stuff should be : > > removed from critical bootstrap tools with extreme prejudice. : > : > I hope you mean including the __FreeBSD_version wart. : : Actually, the __FreeBSD_version tests might be pretty complicated now. : Especially since it comes from different headers. <osreldate.h> on older : systems, <sys/param.h> on newer ones. I'd rather we just reset make back : to use __RCSID (since that is in all BSD sys/cdefs.h) or plain static const : char rcsid[] = "string"; since that works on everything. But *definately* : not __FBSDID here, the #if's and crud needed to make this work would be worse : than any percieved cosmetic gain from using __FBSDID(). So what's the proceedure for making this so. Given that you and I and maybe bde agree that we should revert back to __RCSID, why not just do it and declare it verboten to change it back until 6.0 or so. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020902.143452.50744905.imp>