Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 14 Jun 2007 08:54:17 +1200
From:      Andrew Thompson <thompsa@FreeBSD.org>
To:        "Bruce M. Simpson" <bms@FreeBSD.org>
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/net if_bridge.c if_bridgevar.h src/sbin/ifconfig ifbridge.c
Message-ID:  <20070613205417.GA11671@heff.fud.org.nz>
In-Reply-To: <4670464C.8060304@FreeBSD.org>
References:  <200706131858.l5DIw4Yr009448@repoman.freebsd.org> <4670464C.8060304@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jun 13, 2007 at 08:32:28PM +0100, Bruce M. Simpson wrote:
> Andrew Thompson wrote:
> >  Log:
> >  Add the vlan tag to the bridge route table. This allows a vlan trunk to 
> >  be
> >  bridged, previously legitimate traffic was not passed as the bridge 
> >  could not
> >  tell that it was on a different Ethernet segment.
> >  
> 
> Very cool. Thanks for doing this.
 
Your vtag changes made this very easy.

> >  
> >  All non-tagged traffic is treated as vlan1 as per IEEE 802.1Q-2003
> >  
> Grrr. Made me look. ;-)
> 
> I had confused this with the definition of untagged frame/priority 
> frame. The ethernet input path now does the right thing with VLAN ID 0, 
> so it should play fine with this change.

I have priority frames mapped to vlan1 in bridge_rtupdate, as far as I
can tell this is correct.

2325: bridge_rtupdate(...)
2334:        /* 802.1p frames map to vlan 1 */
2335:        if (vlan == 0)
2336:                vlan = 1;


Andrew



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070613205417.GA11671>