Date: Mon, 8 Apr 2013 15:05:58 +0300 From: Shteryana Shopova <syrinx@FreeBSD.org> To: lev@freebsd.org Cc: "freebsd-net@FreeBSD.org" <freebsd-net@freebsd.org>, Harti Brandt <hartmut.brandt@dlr.de>, Harti Brandt <harti@freebsd.org> Subject: Re: BSNMPD: several (cosmetic?) problems Message-ID: <CAExw9961whpk=b-y9nrK2eHDJGa=meny4VSO41JbV9dvmBT3ww@mail.gmail.com> In-Reply-To: <1192096458.20130408155124@serebryakov.spb.ru> References: <563362676.20130407121102@serebryakov.spb.ru> <alpine.BSF.2.00.1304081338160.34115@KNOP-BEAGLE.kn.op.dlr.de> <1192096458.20130408155124@serebryakov.spb.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
--089e011763b984832f04d9d842a0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi, The patch in question can be found at http://people.freebsd.org/~syrinx/snmp/libbsnmp-20121029-01.diff , I am also attaching it to this e-mail. I didn't commit it yet, since I did not manage to get it properly reviewed or get confirmation from Harti that it solved his problem. Error responses worked fine when I last tested the patch, but it's always good to receive feedback from other testers. cheers, Shteryana On Mon, Apr 8, 2013 at 2:51 PM, Lev Serebryakov <lev@freebsd.org> wrote: > Hello, Harti. > You wrote 8 =D0=B0=D0=BF=D1=80=D0=B5=D0=BB=D1=8F 2013 =D0=B3., 15:40:07: > > LS>>(1) I have a lot of "could not encode error response" in > LS>>/var/log/messages after change of hardware. It looks like, every > LS>>request from mrtg for "unexistent" interface leads to this message. > LS>>I'll reconfigure mrtg, of course, but it is annoying. > HB> I think this is a problem I have already got a patch for from Steryan= a, > HB> but did not manage yet to test. If it is that problem, then it is not > HB> entirely cosmetic, because the daemon fails to send error responses i= n > HB> many cases. > Could you send this patch to me for test? > > -- > // Black Lion AKA Lev Serebryakov <lev@FreeBSD.org> > > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > --089e011763b984832f04d9d842a0 Content-Type: application/octet-stream; name="libbsnmp-20121029-01.diff" Content-Disposition: attachment; filename="libbsnmp-20121029-01.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hf9lg0p60 SW5kZXg6IHNubXAuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzbm1wLmgJKHJldmlzaW9uIDI0MTY4NSkKKysr IHNubXAuaAkod29ya2luZyBjb3B5KQpAQCAtMTgyLDcgKzE4Miw3IEBACiAKIAkvKiBmaXhlcyBm b3IgZW5jb2RpbmcgKi8KIAlzaXplX3QJCQlvdXRlcl9sZW47Ci0Jc2l6ZV90CQkJc2NvcGVkX2xl bjsKKwlhc25fbGVuX3QJCXNjb3BlZF9sZW47CiAJdV9jaGFyCQkJKm91dGVyX3B0cjsKIAl1X2No YXIJCQkqZGlnZXN0X3B0cjsKIAl1X2NoYXIJCQkqZW5jcnlwdGVkX3B0cjsKSW5kZXg6IHNubXBh Z2VudC5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIHNubXBhZ2VudC5jCShyZXZpc2lvbiAyNDE2ODUpCisrKyBz bm1wYWdlbnQuYwkod29ya2luZyBjb3B5KQpAQCAtMTY2LDcgKzE2Niw3IEBACiB9CiAKIHN0YXRp YyB2b2lkCi1zbm1wX3BkdV9jcmVhdGVfcmVzcG9uc2Uoc3RydWN0IHNubXBfcGR1ICpwZHUsIHN0 cnVjdCBzbm1wX3BkdSAqcmVzcCkKK3NubXBfcGR1X2NyZWF0ZV9yZXNwb25zZShjb25zdCBzdHJ1 Y3Qgc25tcF9wZHUgKnBkdSwgc3RydWN0IHNubXBfcGR1ICpyZXNwKQogewogCW1lbXNldChyZXNw LCAwLCBzaXplb2YoKnJlc3ApKTsKIAlzdHJjcHkocmVzcC0+Y29tbXVuaXR5LCBwZHUtPmNvbW11 bml0eSk7CkBAIC05NTIsMTkgKzk1Miw1OCBAQAogc25tcF9tYWtlX2VycnJlc3AoY29uc3Qgc3Ry dWN0IHNubXBfcGR1ICpwZHUsIHN0cnVjdCBhc25fYnVmICpwZHVfYiwKICAgICBzdHJ1Y3QgYXNu X2J1ZiAqcmVzcF9iKQogeworCXVfY2hhciB0eXBlOwogCWFzbl9sZW5fdCBsZW47CiAJc3RydWN0 IHNubXBfcGR1IHJlc3A7CiAJZW51bSBhc25fZXJyIGVycjsKIAllbnVtIHNubXBfY29kZSBjb2Rl OwogCi0JbWVtc2V0KCZyZXNwLCAwLCBzaXplb2YocmVzcCkpOworCXNubXBfcGR1X2NyZWF0ZV9y ZXNwb25zZShwZHUsICZyZXNwKTsKKwogCWlmICgoY29kZSA9IHNubXBfcGR1X2RlY29kZV9oZWFk ZXIocGR1X2IsICZyZXNwKSkgIT0gU05NUF9DT0RFX09LKQogCQlyZXR1cm4gKFNOTVBfUkVUX0lH Tik7CiAKLQlpZiAocGR1X2ItPmFzbl9sZW4gPCBsZW4pCi0JCXJldHVybiAoU05NUF9SRVRfSUdO KTsKLQlwZHVfYi0+YXNuX2xlbiA9IGxlbjsKKwlpZiAocGR1LT52ZXJzaW9uID09IFNOTVBfVjMp IHsKKwkJaWYgKHJlc3AudXNlci5wcml2X3Byb3RvICE9IFNOTVBfUFJJVl9OT1BSSVYgJiYKKwkJ ICAgKGFzbl9nZXRfaGVhZGVyKHBkdV9iLCAmdHlwZSwgJnJlc3Auc2NvcGVkX2xlbikgIT0gQVNO X0VSUl9PSworCQkgICB8fCB0eXBlICE9IEFTTl9UWVBFX09DVEVUU1RSSU5HKSkgeworCQkJc25t cF9lcnJvcigiY2Fubm90IGRlY29kZSBlbmNyeXB0ZWQgcGR1Iik7CisJCQlyZXR1cm4gKFNOTVBf Q09ERV9GQUlMRUQpOworCQl9CiAKKwkJaWYgKGFzbl9nZXRfc2VxdWVuY2UocGR1X2IsICZsZW4p ICE9IEFTTl9FUlJfT0spIHsKKwkJCXNubXBfZXJyb3IoImNhbm5vdCBkZWNvZGUgc2NvcGVkIHBk dSBoZWFkZXIiKTsKKwkJCXJldHVybiAoU05NUF9DT0RFX0ZBSUxFRCk7CisJCX0KKworCQlsZW4g PSBTTk1QX0VOR0lORV9JRF9TSVo7CisJCWlmIChhc25fZ2V0X29jdGV0c3RyaW5nKHBkdV9iLCAo dV9jaGFyICopcmVzcC5jb250ZXh0X2VuZ2luZSwKKwkJICAgICZsZW4pICE9IEFTTl9FUlJfT0sp IHsKKwkJCXNubXBfZXJyb3IoImNhbm5vdCBkZWNvZGUgbXNnIGNvbnRleHQgZW5naW5lIik7CisJ CQlyZXR1cm4gKFNOTVBfQ09ERV9GQUlMRUQpOworCQl9CisJCXJlc3AuY29udGV4dF9lbmdpbmVf bGVuID0gbGVuOworCQlsZW4gPSBTTk1QX0NPTlRFWFRfTkFNRV9TSVo7CisJCWlmIChhc25fZ2V0 X29jdGV0c3RyaW5nKHBkdV9iLCAodV9jaGFyICopcmVzcC5jb250ZXh0X25hbWUsCisJCSAgICAm bGVuKSAhPSBBU05fRVJSX09LKSB7CisJCQlzbm1wX2Vycm9yKCJjYW5ub3QgZGVjb2RlIG1zZyBj b250ZXh0IG5hbWUiKTsKKwkJCXJldHVybiAoU05NUF9DT0RFX0ZBSUxFRCk7CisJCX0KKwkJcmVz cC5jb250ZXh0X25hbWVbbGVuXSA9ICdcMCc7CisJfQorCisKKwlpZiAoYXNuX2dldF9oZWFkZXIo cGR1X2IsICZ0eXBlLCAmbGVuKSAhPSBBU05fRVJSX09LKSB7CisJCXNubXBfZXJyb3IoImNhbm5v dCBnZXQgcGR1IGhlYWRlciIpOworCQlyZXR1cm4gKFNOTVBfQ09ERV9GQUlMRUQpOworCX0KKwor CWlmICgodHlwZSAmIH5BU05fVFlQRV9NQVNLKSAhPQorCSAgICAoQVNOX1RZUEVfQ09OU1RSVUNU RUQgfCBBU05fQ0xBU1NfQ09OVEVYVCkpIHsKKwkJc25tcF9lcnJvcigiYmFkIHBkdSBoZWFkZXIg dGFnIik7CisJCXJldHVybiAoU05NUF9DT0RFX0ZBSUxFRCk7CisJfQorCiAJZXJyID0gc25tcF9w YXJzZV9wZHVzX2hkcihwZHVfYiwgJnJlc3AsICZsZW4pOwogCWlmIChBU05fRVJSX1NUT1BQRUQo ZXJyKSkKIAkJcmV0dXJuIChTTk1QX1JFVF9JR04pOwo= --089e011763b984832f04d9d842a0--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAExw9961whpk=b-y9nrK2eHDJGa=meny4VSO41JbV9dvmBT3ww>