Date: Wed, 2 Mar 2011 08:30:01 -0600 From: Brandon Gooch <jamesbrandongooch@gmail.com> To: Bernhard Froehlich <decke@freebsd.org> Cc: freebsd-emulation@freebsd.org, Julian Elischer <julian@freebsd.org>, freebsd-virtualization@freebsd.org Subject: Re: VirtualBox + VIMAGE Message-ID: <AANLkTimZG0cwXhNdaF5Uv16HfJ299oeexrUSMc7MKE_Q@mail.gmail.com> In-Reply-To: <c51ff723c5ffb7109b7be6e3cf8f7014@bluelife.at> References: <86oc77heqk.fsf@kopusha.home.net> <4D3D2DE9.2060004@freebsd.org> <86tygwy9p0.fsf@kopusha.home.net> <4D3F8357.2070005@freebsd.org> <62fcd16074e526547c3417a8f259174e@bluelife.at> <8662tbkahz.fsf@zhuzha.ua1> <c51ff723c5ffb7109b7be6e3cf8f7014@bluelife.at>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jan 26, 2011 at 5:19 PM, Bernhard Froehlich <decke@freebsd.org> wro= te: > On Wed, 26 Jan 2011 16:25:28 +0200, Mikolaj Golub wrote: >> On Wed, 26 Jan 2011 10:22:40 +0100 Bernhard Froehlich wrote: >> >> =A0BF> Sounds like it's my turn now. Which FreeBSD version is required t= o be >> =A0BF> able to use it? >> >> As Bjoern noted it is for __FreeBSD_version >=3D 800500. >> >> =A0BF> Is VIMAGE enabled per default and what happens if VIMAGE is disab= led - >> =A0BF> does it at least build fine with that patch? >> >> We have VIMAGE disabled by default. >> >> I have added to src/VBox/HostDrivers/VBoxNetFlt/freebsd/Makefile: >> >> .if defined(VIMAGE) >> =A0CFLAGS +=3D -DVIMAGE >> .endif >> >> So to build the driver for VIMAGE enabled kernel one should run >> >> VIMAGE=3D1 make >> >> If VIMAGE variable is not defined the module for VIMAGE disabled kernel = will >> be built. > > http://home.bluelife.at/patches/virtualbox-ose-kmod-devel-VIMAGE.diff > > I've integrated it a bit better into the VirtualBox build system, added > the ports stuff and updated the patch for VirtualBox 4.0.2. > > It is currently unclear to me why you add VIMAGE to CFLAGS but nowhere > check for VIMAGE in VBoxNetFlt-freebsd.c. Shouldn't we add a check for > VIMAGE in the #if defined line or is this already done somewhere deep in > the included headers? > > -- > Bernhard Froehlich > http://www.bluelife.at/ I managed to completely miss your patch posted this thread, so I just gave it a try on bluelife's virtualbox-ose-kmod svn r1239; it's working well. I've started each of my guests with bridged networking to be sure, and I see no panic (or any other anomaly) during boot or normal operation. Do you have plans on merging the patch soon? -Brandon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTimZG0cwXhNdaF5Uv16HfJ299oeexrUSMc7MKE_Q>