Date: Wed, 1 May 2013 02:30:01 GMT
From: Tadaaki Nagao <abtk@shitamachi.org>
To: freebsd-ports-bugs@FreeBSD.org
Subject: Re: ports/178250: Fix build failures of japanese/{mozc-server, mozc-tool, ibus-mozc, mozc-el}
Message-ID: <201305010230.r412U1Eg002144@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/178250; it has been noted by GNATS.
From: Tadaaki Nagao <abtk@shitamachi.org>
To: hrs@FreeBSD.org
Cc: freebsd-gnats-submit@FreeBSD.org, abtk@shitamachi.org
Subject: Re: ports/178250: Fix build failures of japanese/{mozc-server,
mozc-tool, ibus-mozc, mozc-el}
Date: Wed, 01 May 2013 11:21:12 +0900 (JST)
Hi Hiroki-san,
In "Re: ports/178250: Fix build failures of japanese/{mozc-server, mozc-tool, ibus-mozc, mozc-el}",
Hiroki Sato <hrs@FreeBSD.org> wrote:
> ab> But I agree with you that those BUILD_DEPENDS should be got rid of in
> ab> favor of some other preferable ways. I will look into this, but it will
> ab> take some time because Mozc's build system looks to me too complicated
> ab> to understand. In the meanwhile, how about applying my patch as a quick
> ab> fix for the current breakage, and having refinements later as a second
> ab> step.
>
> I already submitted a similar fix. Can you review it?
>
> http://people.allbsd.org/~hrs/FreeBSD/mozc_port_20130428-2.diff (patch)
> http://people.allbsd.org/~hrs/FreeBSD/mozc_port_full_20130428-2.tar.gz (tarball of the patched ports)
Great!
Your patch looks almost fine to me (about nit-picking, see below) and it
worked flawlessly for me. I tested building of mozc-server, mozc-tool,
ibus-mozc and mozc-el on FreeBSD 9-STABLE amd64 and 9.1-RELEASE-p3 i386.
I noticed two small things in your patch:
- fcitx-mozc and ibus-mozc now have PKGNAMESUFFIX=-server. Considering
they didn't have it previously, nor did other fcitx-* and ibus-*
ports, I guess this isn't what you intended.
- In the newly created patch to build_mozc.py, 'openssl_cflags' in the
following line should be 'openssl_ldflags'.
+ openssl_ldflags = options.openssl_cflags or ''
> Although I received a build error report in some environment and
> still investigating it, this should fix wrong parts (including style
> clean-ups) as far as I can see.
Thanks,
Tadaaki Nagao <abtk@shitamachi.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201305010230.r412U1Eg002144>