Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 14 Feb 1998 12:19:10 -0500 (EST)
From:      Tim Vanderhoek <ac199@hwcn.org>
To:        Garrett Wollman <wollman@khavrinen.lcs.mit.edu>
Cc:        Tim Vanderhoek <hoek@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG
Subject:   Re: cvs commit: doc/handbook submitters.sgml
Message-ID:  <Pine.BSF.3.96.980214113756.448B-100000@localhost>
In-Reply-To: <199802141531.KAA03672@khavrinen.lcs.mit.edu>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 14 Feb 1998, Garrett Wollman wrote:

> >   Consider compressing submitted patches if >20KB.
>   
> Well, I hope they will consider it, and then decide against it.  I for

Okay, this is referring specifically to patches which are sent in
bug forms a-la send-pr(1), not patches to -hackers or -current.
Sorry if there was any confusion.

At least one person has complained that they don't really have
the mail capacity to handle these unnecessarily large mails.
This may be the 90's, and it is easy, I suspect, to take good
'net connectivity foregranted.

I suspect many people subscribe to -bugs because they feel it
mandatory to keep-up with the various (potential) bugs in FreeBSD
as part of their job.  They are probably not interested in
monster clear-text patches.

I believe that interest in reviewing, debating, and digesting
patches varies inversely with their size.  The patches should be
accompanied with an appropriate description, and for most people,
this will be sufficient.  How likely are you to read an >20KB
patch, anyways?  Unless it involves something you specifically
are working on, you will probably do little more than glance over
it --- not take any real valuable action such as review and
commit/reject it.

Further, they will also bloat the pr database --- text searches
with query-pr are already _WAY_ too slow for my tastes.  Is
anyone interested in hacking on query-pr and speeding this up
significantly?  Have you tried using even "query-pr --text"
recently?  That's a pretty important function...

Well?  Do a significant portion of people who ignored the
original discussion (innocently not realizing its relevence)
refuse to look-at, consider, or use stuff that is encoded?  (How
do these people get any of their software? ;-)  This is really
just a change that should have gone in with the original commit
advising people to use send-pr to submit changes...  Would you
raise the limit another 5KB or so?

> read.  (Unlike Dan Bernstein, I can't do LZ compression in my head.)

My unforgettable grade 9 math teacher would have said it promotes
good mental discipline.  Besides, real hackers program with
``echo '@#FVZ' > new_prog.tgz''.  :)


--
 tIM...HOEk
OPTIMIZATION: the process of using many one-letter variables names
              hoping that the resultant code will run faster.


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.96.980214113756.448B-100000>