Date: Wed, 28 Oct 2009 09:42:20 -0400 (EDT) From: Steven Kreuzer <skreuzer@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Cc: marcus@FreeBSD.org Subject: ports/140048: [PATCH] ports-mgmt/portlint: Whitelist certain MASTER_SITES Message-ID: <200910281342.n9SDgKYW059150@slurry.exit2shell.com> Resent-Message-ID: <200910281350.n9SDo2ig053157@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 140048
>Category: ports
>Synopsis: [PATCH] ports-mgmt/portlint: Whitelist certain MASTER_SITES
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Wed Oct 28 13:50:01 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Steven Kreuzer
>Release: FreeBSD 7.1-PRERELEASE amd64
>Organization:
>Environment:
System: FreeBSD slurry.exit2shell.com 7.1-PRERELEASE FreeBSD 7.1-PRERELEASE #3: Mon Nov 24 14:01:09 EST 2008
>Description:
I would like to propose the following change to portlint to silence
the warning when only one MASTER_SITES is defined under certain
conditions.
It adds a variable that is a list of "cloud" providers such as
google code that appear as a single site but are, in theory,
massively redundant. If a whitelisted site is set for MASTER_SITES,
it doesn't throw that warning.
Port maintainer (marcus@FreeBSD.org) is cc'd.
Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
>Fix:
--- portlint-2.12.1_1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /usr/share/cvs/freebsd/ports/ports-mgmt/portlint/Makefile,v
retrieving revision 1.134
diff -u -u -r1.134 Makefile
--- Makefile 18 Jul 2009 21:39:07 -0000 1.134
+++ Makefile 12 Oct 2009 15:40:06 -0000
@@ -9,6 +9,7 @@
PORTNAME= portlint
PORTVERSION= 2.12.1
+PORTREVISION= 1
CATEGORIES= ports-mgmt
MASTER_SITES= # none
DISTFILES= # none
Index: src/portlint.pl
===================================================================
RCS file: /usr/share/cvs/freebsd/ports/ports-mgmt/portlint/src/portlint.pl,v
retrieving revision 1.111
diff -u -u -r1.111 portlint.pl
--- src/portlint.pl 18 Jul 2009 21:39:07 -0000 1.111
+++ src/portlint.pl 12 Oct 2009 15:53:59 -0000
@@ -2293,7 +2293,8 @@
}
# check number of MASTER_SITES
- if ($makevar{MASTER_SITES} ne '') {
+ my @mastersites_whitelist = qw(googlecode.com);
+ if (($makevar{MASTER_SITES} ne '') && ($makevar{MASTER_SITES} !~ m/@mastersites_whitelist/)) {
my @sites = split(/\s+/, $makevar{MASTER_SITES});
if (scalar(@sites) == 1) {
&perror("WARN", $file, -1, "only one MASTER_SITE configured. ".
--- portlint-2.12.1_1.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200910281342.n9SDgKYW059150>