Date: Sun, 06 Jun 2004 09:56:41 +0200 From: Oliver Eikemeier <eikemeier@fillmore-labs.com> To: Joe Marcus Clarke <marcus@FreeBSD.org> Cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/devel/portlint Makefileports/devel/portlint/src portlint.pl Message-ID: <40C2CE39.5030402@fillmore-labs.com> In-Reply-To: <200406060106.i5616XNX076254@repoman.freebsd.org> References: <200406060106.i5616XNX076254@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Joe Marcus Clarke wrote: > * Check distinfo to make sure each file in DISTFILES has SIZE and MD5 entries > if NO_SIZE and NO_CHECKSUM are not defined I believe this change serves no useful purpose and should be undone: - no rule mandates the use of SIZE in distfiles. `make makesum' adds it by default, so if it is missing it is removed on purpose, e.g. to account for an mirror that has an broken http server. - the patch does not check PATCHFILES - the check fails for DISTFILES that use :group notation - bsd.port.mk already checks whether distinfo is consitent in terms of existing MD5 lines, no point in repeating this check in portlint - the patch mandates SIZE lines for distfiles which are added to IGNOREFILES and have MD5 (...) = IGNORE, which makes no sense. Generally patches like this should be checked with portlintgrep to see what ports they flag, and whether they solve an existing or potential problem in the ports tree. -Oliver
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?40C2CE39.5030402>