Date: Thu, 2 Dec 1999 22:11:23 -0500 (EST) From: Andrew Gallatin <gallatin@cs.duke.edu> To: mjacob@feral.com Cc: mckusick@mckusick.com, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/sys mount.h src/sys/kern vfs_bio.c src/sys/miscfs/specfs spec_vnops.c Message-ID: <14407.13249.163881.210052@grasshopper.cs.duke.edu> In-Reply-To: <Pine.BSF.4.05.9912021902430.6279-100000@semuta.feral.com> References: <14407.12580.411786.947071@grasshopper.cs.duke.edu> <Pine.BSF.4.05.9912021902430.6279-100000@semuta.feral.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Matthew Jacob writes: > > I did indeed see that Jordan committed the change. I would personally have > preferred to see explicit size values instead. Why did you choose to > truncate the name storage rather than change the 'longs' to 'int32_t's? Primarily because it seemed to be in the spirit of Kirk's original patch to carve space out of the string. Also, it seemed rather expediant & I wanted to get it committed quickly. I wanted to prevent people from getting nailed by a combo of the bdev elimination & the mount incompatability this problem introduced. From you message on -current, it looks like you were a victim of just this. Drew ------------------------------------------------------------------------------ Andrew Gallatin, Sr Systems Programmer http://www.cs.duke.edu/~gallatin Duke University Email: gallatin@cs.duke.edu Department of Computer Science Phone: (919) 660-6590 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?14407.13249.163881.210052>