Date: Fri, 04 Dec 1998 18:09:15 -0800 From: Mike Smith <mike@smith.net.au> To: Greg Lehey <grog@lemis.com> Cc: Warner Losh <imp@village.org>, "Jordan K. Hubbard" <jkh@zippy.cdrom.com>, Steve Kargl <sgk@troutmask.apl.washington.edu>, "Robert V. Baron" <rvb@cs.cmu.edu>, wollman@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: Requiring make depend (was: cvs commit: src/sys/sys bus.h bus_private.h conf.h devicestat.h module.h src/sys/kern bus_if.m device_if.m kern_con) Message-ID: <199812050209.SAA01724@dingo.cdrom.com> In-Reply-To: Your message of "Sat, 05 Dec 1998 12:35:59 %2B1030." <19981205123559.O603@freebie.lemis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Friday, 4 December 1998 at 18:47:20 -0700, Warner Losh wrote: > > In message <2140.912819552@zippy.cdrom.com> "Jordan K. Hubbard" writes: > > : Perhaps not, but this is very definitely now the case in 3.0. If you > > : don't make depend first, the build won't even complete. > > > > I understand that. make depend fixes this, but it is a bug none the > > less. > > > > I'm just saying that even in the face of make -j, the makefile that is > > generated should have the proper dependencies in it to ensure that the > > generated files are build prior to their use. Relying on make depend > > to do this is an ugly kludge. We've had generated files for years > > before the current bus stuff was added that didn't cause this > > problem. I've fixed it once already... > > I agree with this sentiment. make depend should make dependency > information, not header files. The Makefiles should have rules to > make any necessary header files. They do. But without the dependancy information generated by 'make depend', make can't tell that it needs to generate the header files before building things that include them. 'make depend' should be *mandatory*, as the alternative involves duplicating dependancy information in the source and in the configuration infrastructure. -- \\ Sometimes you're ahead, \\ Mike Smith \\ sometimes you're behind. \\ mike@smith.net.au \\ The race is long, and in the \\ msmith@freebsd.org \\ end it's only with yourself. \\ msmith@cdrom.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199812050209.SAA01724>