Date: Tue, 25 Mar 2014 19:45:28 +0100 From: Guido Falsi <madpilot@FreeBSD.org> To: Tijl Coosemans <tijl@FreeBSD.org>, mat@FreeBSD.org, perl@FreeBSD.org Subject: Re: svn commit: r349107 - in head/converters/p5-Text-Iconv: . files Message-ID: <5331CEC8.9040504@FreeBSD.org> In-Reply-To: <20140325154013.06cfd18a@kalimero.tijl.coosemans.org> References: <201403250723.s2P7N6cc052424@svn.freebsd.org> <20140325154013.06cfd18a@kalimero.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 03/25/14 15:40, Tijl Coosemans wrote: > Thanks, I received a PR about this yesterday: > http://www.freebsd.org/cgi/query-pr.cgi?pr=187907 > > The OSVERSION check isn't correct though. It should be empty(ICONV_LIB). > But, I've attached a patch that uses a different approach. You can > make the port use /usr/include/iconv.h by replacing LOCALBASE in > CONFIGURE_ARGS with ICONV_PREFIX. > > That fixes the build phase, during configure however, something(?) is > still adding -I/usr/local/include to the command line so you still need > -DLIBICONV_PLUG when empty(ICONV_LIB). The patch adds CFLAGS to INC in > CONFIGURE_ARGS for this. You can verify this by adding verbose=1 to > CONFIGURE_ARGS and running "make configure". > > Can perl@ review/approve this? I did not think about stuffing CFLAGS in INC, good catch! :) I did not see that PR, I would have filed my patch as followup if I had. -- Guido Falsi <madpilot@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5331CEC8.9040504>